Resources: modified AsyncCache to use Dispatchers.Unconfined - #5688
Open
Konstantin (terrakok) wants to merge 2 commits into
Open
Resources: modified AsyncCache to use Dispatchers.Unconfined#5688Konstantin (terrakok) wants to merge 2 commits into
AsyncCache to use Dispatchers.Unconfined#5688Konstantin (terrakok) wants to merge 2 commits into
Conversation
…start shared requests lazily outside the critical mutex section.
…add deadlock reproduction example.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resources: modified
AsyncCacheto useDispatchers.Unconfinedand start shared requests lazily outside the critical mutex section.The issue was that, inside
AsyncCache, requests to the same resource were reused viaasync, which by default scheduled its work onDispatchers.Default. That dispatcher could be overloaded with tasks, which in turn forced theMainthread to wait longer than allowed, resulting in anANR.Fixes https://youtrack.jetbrains.com/issue/CMP-6615
Testing
Added new unit tests
Release Notes
Fixes - Resources
Dispatchers.Defaultis overloaded.