fix: EXPOSED-987 Add withParentheses to set operations for correct precedence - #2776
Open
Christopher Jenkins (chrisjenx) wants to merge 1 commit into
Conversation
…ecedence Add a withParentheses parameter (default true) to union(), unionAll(), intersect(), and except() extension functions in both JDBC and R2DBC modules. When true, wraps any preceding set operation in parentheses so the DSL chain order matches the SQL evaluation order. Also fixes Except.copy() which incorrectly returned Intersect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
withParenthesesparameter (defaulttrue) tounion(),unionAll(),intersect(),except()extension functions in both JDBC and R2DBC modulestrue, wraps any preceding set operation in parentheses so the DSL chain order matches SQL evaluation orderExcept.copy()which incorrectly returnedIntersectinstead ofExceptMotivation
When chaining
query1.union(query2).intersect(query3), SQL operator precedence causes INTERSECT to bind tighter than UNION, producing incorrect results. This adds parenthesization so the DSL chain order is respected:(SELECT 1 UNION SELECT 2) INTERSECT SELECT 3.Approach suggested by @chantal-loncle in EXPOSED-987.
Test plan
testIntersectWithThreeQueriesto verify deterministic results with default parenthesestestIntersectWithoutParenthesesto verifywithParentheses = falsepreserves legacy behaviortestSetOperationGeneratesParenthesesto verify SQL string output./gradlew :exposed-tests:test_h2_v2 --tests "*.UnionTests"— all pass./gradlew :exposed-r2dbc-tests:test_h2_v2 --tests "*.UnionTests"— all pass./gradlew detekt— clean./gradlew apiCheck— cleanGenerated with Claude Code