Fix #505: Prevent silent XXE on PHP < 8.0 - #506
Merged
JamesHeinrich merged 1 commit intoSep 10, 2026
Merged
Conversation
…y_loader() and add LIBXML_NOENT - Remove @ error suppression on libxml_disable_entity_loader() calls in XML2array() so failures are not silently ignored on PHP < 8.0 - Add explicit check: if disabling entity loading fails, return false instead of proceeding with XXE enabled - Add LIBXML_NOENT to GETID3_LIBXML_OPTIONS as defence-in-depth to explicitly disable external entity substitution at the parser level Ref: CWE-611, JamesHeinrich#505
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #505
Changes
Removed
@error suppression fromlibxml_disable_entity_loader()calls inXML2array()(lines 749, 752). On PHP < 8.0, if this call fails silently, external entity loading remains enabled, allowing XXE attacks via crafted media metadata.Added explicit failure check: if
libxml_disable_entity_loader(true)fails, the function now returnsfalseinstead of proceeding to parse untrusted XML with external entities enabled.Added
LIBXML_NOENTtoGETID3_LIBXML_OPTIONSas defence-in-depth, explicitly disabling external entity substitution at the libxml parser level.Impact