Repository navigation
🐛 fix(showcase): keep the labs off a phone's Search, and say so when one is reached - #120
Merged
Merged
Conversation
…one is reached Follow-up to #117, which stopped offering Graph and Glitch Lab on a phone from the header and Home but left two ways in. Search (⌘K) still listed both labs at any width. The palette now leaves them out below 640px, read live from the new phone.ts (PHONE_QUERY, useIsPhone), which holds the CSS breakpoint for script. A lab reached on a phone anyway, from a shared link, mounted a desktop console that does not fit. It now says it is built for a desktop, with links to the docs and Home and an "Open it anyway" button. Each lab is keyed, so opening one anyway does not open the other. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to #117, which stopped offering Graph and Glitch Lab on a phone (under 640px) from the header and Home, because both are docked desktop consoles with no phone layout. Two ways in were left open:
phone.tsholds the 640px breakpoint for script (PHONE_QUERY,useIsPhoneoveruseSyncExternalStore), cross-referenced from the CSS rule that hides the labs.Checklist
npm run lint: not run locally (eslint-plugin-sonarjsis missing from this checkout); CI is the check.npm run typechecknpm run test/test:coverage: local Node 20.20 is below the repo's ≥22.12 floor; CI is the check. No unit-tested code changes.packages/*/srcchanges.<button>for "Open it anyway".Notes for the reviewer
🤖 Generated with Claude Code