Skip to content

Fix plisql tripword and wordtype package-datum handling - #1651

Closed
Aias00 wants to merge 1 commit into
IvorySQL:masterfrom
Aias00:fix/plisql-compile-fixes-1648
Closed

Fix plisql tripword and wordtype package-datum handling#1651
Aias00 wants to merge 1 commit into
IvorySQL:masterfrom
Aias00:fix/plisql-compile-fixes-1648

Conversation

@Aias00

@Aias00 Aias00 commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes #1648.

  1. plisql_parse_tripword (src/pl/plisql/src/pl_comp.c): return true moved into the PKG_VAR case (matching plisql_parse_dblword); a a.b.c reference resolving to a non-variable package entry now falls through instead of returning true with wdatum->datum uninitialized.
  2. plisql_parse_wordtype: PLISQL_DTYPE_PACKAGE_DATUM datums (standard-package variables) are now resolved through pkgvar before reading datatype/notnull, instead of mis-casting the package-datum struct (wrong on 32-bit, luck-dependent on 64-bit).

Test plan

  • make -C src/pl/plisql/src pl_comp.o compiles cleanly.

@coderabbitai

coderabbitai Bot commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@Aias00, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 43 minutes

Limit details: You’ve used all 4 included reviews currently available under your plan.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 4be47b6a-ce4b-4b85-889a-fccac8687868

📥 Commits

Reviewing files that changed from the base of the PR and between c3529ba and 8601000.

📒 Files selected for processing (1)
  • src/pl/plisql/src/pl_comp.c

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

- plisql_parse_tripword: return true only from the PKG_VAR case
  (matching plisql_parse_dblword); a non-variable package entry now
  falls through instead of returning true with wdatum->datum
  uninitialized
- plisql_parse_wordtype: resolve PLISQL_DTYPE_PACKAGE_DATUM datums
  through pkgvar before reading datatype/notnull, avoiding a
  mis-cast of the package-datum struct

Closes IvorySQL#1648

Signed-off-by: liuhongyu <liuhongyu@apache.org>
@Aias00
Aias00 force-pushed the fix/plisql-compile-fixes-1648 branch from e0d6e00 to 8601000 Compare August 17, 2026 02:37
@NotHimmel

Copy link
Copy Markdown
Collaborator

Thanks for the PR — I still have some questions about the issue, let's discuss those in #1648

@Aias00

Aias00 commented Aug 17, 2026

Copy link
Copy Markdown
Contributor Author

Closing per the verification in #1648 - both code-level defects are real but the triggering PL/iSQL constructs cannot be written with the current grammar (package TYPE entries and standard-package var %TYPE both fail to resolve). Can be resubmitted if a maintainer wants the defensive fixes.

@Aias00 Aias00 closed this Aug 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

plisql: tripword returns true for non-variable package entries; wordtype casts package datums unsafely

2 participants