fix: keep developer messages in DeepSeek-V4 thinking drop - #5015
Open
longzhenren wants to merge 1 commit into
Open
longzhenren wants to merge 1 commit into
longzhenren wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
_drop_thinking_messagesindeepseek_v4_encoding.pydocuments that "Developer messages before the last user are dropped entirely", and itskeep_rolesset indeed lacksdeveloper. But the rest of the module supports the role: the renderer has adeveloperbranch (rendered like a user turn) andfind_last_user_indexcounts it.So in thinking mode with
drop_thinking=True(the default), a developer message before the last user turn is silently removed from the prompt: the instructions never reach the model, and encoding a conversation with or without the developer message produces the same output.Reproduction:
Fix
Add
developertokeep_rolesand update the docstring, consistent with how the renderer andfind_last_user_indexalready treat the role.Test
test_deepseek_v4_thinking_drop_keeps_developer_message:[system, developer, user]in thinking mode renders the developer content.test_deepseek_v4_thinking_drop_keeps_developer_in_multiturn: a developer message before the last user turn survives the drop while assistantreasoning_contentis still stripped.