-
Notifications
You must be signed in to change notification settings - Fork 40
Add dpctl.SyclQueue.memset() method
#2361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vlad-perevezentsev
wants to merge
21
commits into
master
Choose a base branch
from
add_sycl_queue_memset
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
30834c0
Add SyclQueue.memset method
vlad-perevezentsev 4f08b2f
Add tests for SyclQueue.memset
vlad-perevezentsev a591bcf
Add gh-2361 to changelog
vlad-perevezentsev af2da99
Add DPCTLQueue_MemsetWithEvents C-API function
vlad-perevezentsev 4b197d5
Add tests for DPCTLQueue_MemsetWithEvents
vlad-perevezentsev 9d63c23
Add DPCTLQueue_MemsetWithEvents declaration to _backend.pxd
vlad-perevezentsev fd541c0
Add SyclQueue.memset_async method
vlad-perevezentsev 9a3fbe1
Fix typos and improve DPCTLQueue_Memset doc
vlad-perevezentsev c905349
Add tests for SyclQueue.memset_async
vlad-perevezentsev 8e1cfde
Update gh-2361 changelog entry
vlad-perevezentsev 24d58fa
Fix memset_async error message and improve memset docstrings
vlad-perevezentsev 5661ab9
Fix memset value type to uint8_t
vlad-perevezentsev 51c36df
Cover host/device memory and value truncation in memset tests
vlad-perevezentsev b6d9804
Merge remote-tracking branch 'origin/master' into add_sycl_queue_memset
vlad-perevezentsev 0f08fe2
Fix stray semicolons and Count docstring in memset C-API
vlad-perevezentsev 0689902
Add a note about keeping mem alive in memset_async docs
vlad-perevezentsev 7240bad
Cast self to SyclQueue in memset_async
vlad-perevezentsev d584ca6
Add test_memset_fills_bytewise
vlad-perevezentsev 5e0630b
Update an error message in DPCTLQueue_MemsetWithEvents
vlad-perevezentsev 7b4bebc
Apply remarks for _sycl_queue.pyx
vlad-perevezentsev 2359b0c
Update test_sycl_queue_memset.py
vlad-perevezentsev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,106 @@ | ||
| # Data Parallel Control (dpctl) | ||
| # | ||
| # Copyright 2026 Intel Corporation | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| """Defines unit test cases for the SyclQueue.memset.""" | ||
|
|
||
| import pytest | ||
|
|
||
| import dpctl | ||
| import dpctl.memory | ||
|
|
||
|
|
||
| def _create_memory(q, nbytes=1024): | ||
|
vlad-perevezentsev marked this conversation as resolved.
|
||
| return dpctl.memory.MemoryUSMShared(nbytes, queue=q) | ||
|
|
||
|
|
||
| def test_memset_fills_whole_allocation(): | ||
| try: | ||
| q = dpctl.SyclQueue() | ||
| except dpctl.SyclQueueCreationError: | ||
| pytest.skip("Default constructor for SyclQueue failed") | ||
| nbytes = 256 | ||
| mobj = _create_memory(q, nbytes) | ||
|
|
||
| q.memset(mobj, 0xAB) | ||
|
|
||
| assert bytes(memoryview(mobj)) == b"\xab" * nbytes | ||
|
|
||
|
|
||
| def test_memset_zero_count_fills_whole_allocation(): | ||
| try: | ||
| q = dpctl.SyclQueue() | ||
| except dpctl.SyclQueueCreationError: | ||
| pytest.skip("Default constructor for SyclQueue failed") | ||
| nbytes = 64 | ||
| mobj = _create_memory(q, nbytes) | ||
|
|
||
| q.memset(mobj, 0x01, 0) | ||
|
|
||
| assert bytes(memoryview(mobj)) == b"\x01" * nbytes | ||
|
|
||
|
|
||
| def test_memset_partial_count(): | ||
| try: | ||
| q = dpctl.SyclQueue() | ||
| except dpctl.SyclQueueCreationError: | ||
| pytest.skip("Default constructor for SyclQueue failed") | ||
| nbytes = 16 | ||
| mobj = _create_memory(q, nbytes) | ||
|
|
||
| # zero-out first, then fill only the leading 4 bytes | ||
| q.memset(mobj, 0x00) | ||
| q.memset(mobj, 0x7F, 4) | ||
|
|
||
| assert bytes(memoryview(mobj)) == b"\x7f" * 4 + b"\x00" * (nbytes - 4) | ||
|
|
||
|
|
||
| def test_memset_count_clamped_to_allocation(): | ||
| try: | ||
| q = dpctl.SyclQueue() | ||
| except dpctl.SyclQueueCreationError: | ||
| pytest.skip("Default constructor for SyclQueue failed") | ||
| nbytes = 8 | ||
| mobj = _create_memory(q, nbytes) | ||
|
|
||
| # requesting more bytes than allocated must not overrun; it is clamped | ||
| q.memset(mobj, 0x02, 4 * nbytes) | ||
|
|
||
| assert bytes(memoryview(mobj)) == b"\x02" * nbytes | ||
|
|
||
|
|
||
| def test_memset_zero_value(): | ||
| try: | ||
| q = dpctl.SyclQueue() | ||
| except dpctl.SyclQueueCreationError: | ||
| pytest.skip("Default constructor for SyclQueue failed") | ||
| nbytes = 32 | ||
| mobj = _create_memory(q, nbytes) | ||
|
|
||
| q.memset(mobj, 0xFF) | ||
| q.memset(mobj, 0) | ||
|
|
||
| assert bytes(memoryview(mobj)) == b"\x00" * nbytes | ||
|
|
||
|
|
||
| def test_memset_type_error(): | ||
| try: | ||
| q = dpctl.SyclQueue() | ||
| except dpctl.SyclQueueCreationError: | ||
| pytest.skip("Default constructor for SyclQueue failed") | ||
|
|
||
| with pytest.raises(TypeError) as cm: | ||
| q.memset(None, 1) | ||
| assert "_Memory" in str(cm.value) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.