Conversation
|
Whats the difference between style in the |
Style directly in the files is scoped, so it doesn't affect other files. It's more logical to do this unless the class is susceptible to be used in at least a few files. So for instance, for the video player, I just want the bottom corners to be rounded, but I'm never going to use that class anywhere else. It would clutter |
|
But I do wonder if I shouldn't just use the |
AFAIK it isn't recommanded because you put style at a lot of different places and it gets hard to maintain |
|
Yeah but is it really better to make classes I only use once |
|
If a class is only use once, it's okay to put it in the file it will be used in |
8a56464 to
7535dbe
Compare
I fixed the links but yeah for the progress bars I don't know. I looked into fixing this back when I created the ProgressBar component, but as far as I can tell there's no way to have alternate "blend modes" with just CSS (which would give us an inverted effect that would guarantee readability). I made #240 if someone wants to look at this in the future. |
Description
This PR refactors all the style code from Tailwind to pure CSS classes, and redesigns the whole frontend using the new graphic charter. I also fixed like 10 other design-related issues.
Checklist
Refactored files (zero Tailwind classes) :
src/App.vuesrc/assets/XLogo.vuesrc/components/AdminPizza/PizzaModal.vuesrc/components/Content.vuesrc/components/Footer.vuesrc/components/FormField.vuesrc/components/Hero.vuesrc/components/LoginForm.vuesrc/components/Map.vuesrc/components/Modal.vuesrc/components/NameConfirmationModal.vuesrc/components/Navigation.vuesrc/components/Notification.vuesrc/components/PartnerCard.vuesrc/components/Partners.vuesrc/components/PasswordInput.vuesrc/components/PasswordResetForm.vuesrc/components/PaymenStatusIcon.vuesrc/components/PaymentStatusIcon.vuesrc/components/PizzaCard.vuesrc/components/Planning.vuesrc/components/ProgressBar.vuesrc/components/RegisterForm.vuesrc/components/StringListInput.vuesrc/components/Tournament/Admin/AdminBracket.vue(318 lines)src/components/Tournament/Admin/AdminGroups.vue(340 lines)src/components/Tournament/Admin/AdminGroupsMatchs.vue(231 lines)src/components/Tournament/Admin/AdminSwiss.vue(383 lines)src/components/Tournament/Admin/TournamentAdminStages.vue(950 lines)src/components/Tournament/Admin/TournamentAdminTeams.vue(149 lines)src/components/Tournament/Bracket.vue(215 lines)src/components/Tournament/GroupDetail.vue(51 lines)src/components/Tournament/GroupTable.vue(361 lines)src/components/Tournament/MatchCard.vue(367 lines)src/components/Tournament/PrivateTournamentCard.vuesrc/components/Tournament/SeatingPlan.vue(325 lines)src/components/Tournament/SwissRoundTable.vue(88 lines)src/components/Tournament/TeamCard.vuesrc/components/Tournament/TournamentBrackets.vue(236 lines)src/components/Tournament/TournamentCard.vuesrc/components/Tournament/TournamentGroups.vue(104 lines)src/components/Tournament/TournamentInfo.vue(216 lines)src/components/Tournament/TournamentPlanning.vuesrc/components/Tournament/TournamentRules.vuesrc/components/Tournament/TournamentSeating.vuesrc/components/Tournament/TournamentStages.vue(161 lines)src/components/Tournament/TournamentSwiss.vue(20 lines)src/components/Tournament/TournamentTeams.vue(131 lines)src/components/Tournament/TravelFormModal.vuesrc/components/TournamentMeCard.vuesrc/views/AdminPizza/AdminPizza.vue(781 lines)src/views/AdminPizza/AdminPizzaExportList.vue(262 lines)src/views/AdminPizza/AdminPizzaList.vue(212 lines)src/views/AdminPizza/PizzaListEl.vuesrc/views/AdminPizza/PizzaModal.vuesrc/views/Archives.vuesrc/views/Association.vuesrc/views/Cart.vuesrc/views/Eat.vuesrc/views/EmailVerif.vuesrc/views/Home.vuesrc/views/Informations.vuesrc/views/Login.vuesrc/views/Logout.vuesrc/views/Me.vuesrc/views/NotFound.vuesrc/views/Register.vuesrc/views/ResetPassword.vuesrc/views/ReturnPayment.vuesrc/views/ScanQrCode.vuesrc/views/Schedule.vuesrc/views/TeamDetail.vuesrc/views/Tournament/Tournament.vuesrc/views/Tournament/TournamentDetail.vuesrc/views/Tournament/TournamentRegister.vuesrc/stores/content.store.tsFinal checks:
layer="override"(used to redefine tailwind classes)<button type="button">tag with atitleattribute) and made all clickable elements buttons (check all c-btn-* instances)CMS changes
Here are the changes that will need to happen to the content on the production website after this is merged :
<span style="color:#48cad9">text</span>with bold**text**;<h1>tags from the home page;#)Adressecontent, that will appear above the map;parti_publictopartie_public;lanfile (File, not Content) which is a photo that will be in the background of the "Association" page (in webp format if possible);Related Issues
Fix #200
Fix #124
Fix #224
Fix #225
Fix #228
Fix #226
Fix #189
Fix #147
Fix #202
Fix #49
Fix #137
Fix #220
Screenshots