-
Notifications
You must be signed in to change notification settings - Fork 24
Adding ty type checking (experimental) #1371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
cdbf1
wants to merge
19
commits into
main
Choose a base branch
from
feature/ty_type_checking
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 9 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
564a5ed
Adding ty type checking
cdbf1 c439ffa
Reformatting
cdbf1 68fe5b4
Fix typing issues in general superstaq
cdbf1 1f39a96
Add tests for coverage of new code in gss
cdbf1 c6a7287
Merge remote-tracking branch 'origin/main' into feature/ty_type_checking
cdbf1 ae7b3a4
Update ci.yaml so that `ty` check only runs on general superstaq
cdbf1 1285569
Merge remote-tracking branch 'origin/main' into feature/ty_type_checking
cdbf1 5b21288
Adding typing extensions to check-superstaq requirements
cdbf1 f3fe984
Drop minimum version for py39
cdbf1 3f7bc69
Merge remote-tracking branch 'origin/main' into feature/ty_type_checking
cdbf1 38cc108
Fixing some things from RR
cdbf1 559ed4b
Update requirements and client type checking
cdbf1 6e11754
Fix tests
cdbf1 fc9eae8
Ignore strict tv typing on pydantic coercion
cdbf1 9692234
Merge remote-tracking branch 'origin/main' into feature/ty_type_checking
cdbf1 8665461
Fixing compiler output typing
cdbf1 3e57e34
Merge branch 'main' into feature/ty_type_checking
cdbf1 be2be31
Set minimum ty python version to check against
cdbf1 44c8c46
Remove bad docs
cdbf1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| #!/usr/bin/env python3 | ||
| # Copyright 2026 Infleqtion | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| import subprocess | ||
| import sys | ||
| import textwrap | ||
| from collections.abc import Iterable | ||
|
|
||
| from checks_superstaq import check_utils | ||
|
|
||
|
|
||
| @check_utils.enable_exit_on_failure | ||
| def run( | ||
| *args: str, | ||
| include: str | Iterable[str] = "*.py", | ||
| exclude: str | Iterable[str] = (), | ||
| silent: bool = False, | ||
| ) -> int: | ||
| """Runs ty on the repository (typing check). | ||
|
|
||
| Args: | ||
| *args: Command line arguments. | ||
| include: Glob(s) indicating which tracked files to consider (e.g. "*.py"). | ||
| exclude: Glob(s) indicating which tracked files to skip (e.g. "*integration_test.py"). | ||
| silent: If True, restrict printing to warning and error messages. | ||
|
|
||
| Returns: | ||
| Terminal exit code. 0 indicates success, while any other integer indicates a test failure. | ||
| """ | ||
| parser = check_utils.get_check_parser() | ||
| parser.description = textwrap.dedent( | ||
| """ | ||
| Runs ty on the repository (typing check). | ||
| Ignores files in the [repo_root]/examples directory. | ||
| """ | ||
| ) | ||
|
|
||
| parsed_args, args_to_pass = parser.parse_known_intermixed_args(args) | ||
| if "ty" in parsed_args.skip: | ||
| return 0 | ||
|
|
||
| files = check_utils.extract_files(parsed_args, include, exclude, silent) | ||
|
|
||
| return subprocess.call( | ||
| [sys.executable, "-m", "ty", "check", *files, *args_to_pass], cwd=check_utils.root_dir | ||
| ) | ||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| sys.exit(run(*sys.argv[1:])) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this handled somewhere? Or are we ignoring it for now since
gsshas noexamples?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, that was because I copied it from somewhere else - thanks for catching!