target model v2 - #1293
Draft
richrines1 wants to merge 9 commits into
Draft
Conversation
Contributor
|
I'm very much in favour of switching to using statuses rather than all the booleans! |
richrines1
marked this pull request as ready for review
November 19, 2025 22:29
dowusu-antwi
self-requested a review
November 26, 2025 16:34
| QUBO = "qubo" | ||
|
|
||
|
|
||
| class TargetDescription(DefaultPydanticModel): |
Contributor
There was a problem hiding this comment.
How about TargetSpecification / TargetSpecs?
pgoiporia
approved these changes
Dec 4, 2025
pgoiporia
left a comment
pgoiporia
left a comment
Contributor
There was a problem hiding this comment.
LGTM. One suggestion but you can probably ignore it.
| accessible=True, | ||
| ) | ||
|
|
||
| with pytest.raises(pydantic.ValidationError, match=r"valid string format"): |
Contributor
There was a problem hiding this comment.
Maybe this is overkill, given that we hit full coverage, but should we be adding the same test for status?
vtomole
marked this pull request as draft
February 18, 2026 17:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
more compact replacement for
TargetModelalso renamed the new model
TargetDescription, but open to other suggestions :)