Repository navigation
fix: improve CLI help and external backend shutdown handling - #259
Merged
Merged
Conversation
chen2021673
force-pushed
the
fix/cli-help-and-test-labels
branch
from
October 30, 2026 06:08
dba9062 to
7917f62
Compare
- Add usage messages to training examples and infini_run - Add Mixtral external backend shutdown workaround and flush output before exit - Include DP rank in distributed optimizer empty-shard errors - Remove accelerator and hardware test labels and update documentation
Collaborator
Author
|
精度测试： |
Chamberlain0w0
approved these changes
Nov 5, 2026
JYMiracle305
requested changes
Nov 5, 2026
Comment on lines
+730
to
+732
| gflags::SetUsageMessage( | ||
| "Train a GPT-2 model with InfiniTrain.\nUsage: " + std::string(argv[0]) + | ||
| " --input_bin=<training.bin> [options]"); |
Contributor
There was a problem hiding this comment.
当前直接 ./gpt --help，会把第三方库里的参数也打出来，这里建议usage加一个提示使用 Model options: --helpmatch=example/gpt2/，或者代码里做一下截获
Collaborator
Author
There was a problem hiding this comment.
已修改：现在默认只打印模型参数，指定helpfull时打印完整参数
Share model help filtering across the training examples and retain --helpfull for all flags. Document the two help modes in usage output and the README.
JYMiracle305
approved these changes
Nov 6, 2026
Collaborator
Author
|
修改后精度性能复测结果： |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
infini_run的命令行用法说明，并完善退出处理、错误诊断和测试标签。修改前和修改后对比：
在分布式优化器空分片错误中输出 DP rank，便于定位异常进程。
移除 CTest 的
accelerator、hardware标签，保留设备或后端标签，并同步更新测试文档。