Skip to content

Shard Windows Included Files scale gate - #831

Merged
Infiland merged 2 commits into
mainfrom
dev/shard-windows-included-files-scale
Aug 10, 2026
Merged

Shard Windows Included Files scale gate#831
Infiland merged 2 commits into
mainfrom
dev/shard-windows-included-files-scale

Conversation

@Infiland

@Infiland Infiland commented Aug 3, 2026

Copy link
Copy Markdown
Owner

Closes #830

What changed

  • Keep the broad native Windows artifact suite but skip only the 10,000-entry Included Files stress test there.
  • Add a dedicated Windows 2025 job with the same Python 3.12.10, locked dependencies, and unchanged 20-minute timeout.
  • Run the exact scale case through a fail-closed module runner that requires one collected and executed pass and rejects skips, failures, expected outcomes, fixture exits, and non-CI use.
  • Lock the dedicated step shape against conditional execution, ignored exits, broader selectors, duplicate invocation, custom shells, and quoted YAML-key bypasses.
  • Keep ordinary local and full-suite discovery unchanged and bump release surfaces to 0.7.53.

Why

Exact PR #829 evidence showed the heavy test consumes about 10m46s, the other 613 tests about 8m36s, and setup about 33s. All 614 tests passed, but their combined job crossed the 20-minute cap during teardown. Separate jobs retain native coverage without increasing the timeout.

Validation

  • Full Included Files module: 174 tests passed, 13 skipped.
  • Exact 10,000-entry case: passed normally and through the required module runner; latest local wrapper run completed one test in 30.979s.
  • Runner and workflow-policy adversarial tests cover empty/duplicate collection, skips at fixture and method boundaries, failures/errors, expected outcomes, SystemExit(0), nonzero status propagation, module entrypoint resolution, quoted control keys, ignored exits, broader selectors, and duplicate invocation.
  • Complete workflow-policy, runner, and version set: 82 tests passed.
  • Coverage-policy, documentation-health, version, and runner set: 32 tests passed.
  • Repository-wide Ruff passed.
  • Pyright: 0 errors, 0 warnings.
  • Three independent adversarial audits found no remaining concrete gate bypass.

The new exact-head native Windows jobs and the clean-environment Linux full suite remain the final acceptance gates.

@Infiland

Copy link
Copy Markdown
Owner Author

Final acceptance evidence for exact head 079e71c65aaa95cb9d6796fc0532849f31c772e2:

  • 20/20 check records resolved: 17 successes and the 3 expected pull-request release skips.
  • windows-included-files-scale: 12m11s total, leaving 7m49s under the unchanged 20-minute cap. Raw output proves GM2GODOT_REQUIRE_WINDOWS_INCLUDED_FILES_SCALE_GATE=1, the exact case ran once in 689.140s, and Ran 1 test / OK with no skip.
  • windows-artifact-transactions: 11m29s total, leaving 8m31s. It ran 616 tests in 651.093s; the exact 10,000-entry case was the intended dedicated-job skip and the suite finished OK (skipped=52).
  • Linux full coverage, Windows crash recovery, macOS transactions, both LTS/TCC conversion gates, Ruff, Pyright, dependency locks, and all release builds passed.
  • Godot smoke used exact 4.7.1.stable.official.a13da4feb; 83 discovery tests and 60 validation/golden/settings tests passed.

The final pushed diff has independent clean adversarial audits and no remaining concrete gate bypass.

@Infiland
Infiland marked this pull request as ready for review August 10, 2026 07:11
@Infiland
Infiland merged commit a1cf146 into main Aug 10, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shard the native Windows 10,000-entry Included Files stress gate

1 participant