Repository navigation
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Python Preview Packages — Publish FailedPreview publish failed for commit 3e6ca94. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security audit followed up on
unit-typescript-sdk.yml(hardening / informational): theDetect fork PRstep interpolatedgithub.event.pull_request.head.repo.full_name(plusgithub.event_name/github.repository) directly into arun:block. There is no practical injection path today (repo/owner naming rules constrain these values), but the interpolation pattern is still worth removing.- name: Detect fork PR id: fork-check + env: + EVENT_NAME: ${{ github.event_name }} + HEAD_REPO_FULL_NAME: ${{ github.event.pull_request.head.repo.full_name }} + REPOSITORY: ${{ github.repository }} run: | - if [[ "${{ github.event_name }}" == "pull_request" && \ - "${{ github.event.pull_request.head.repo.full_name }}" != "${{ github.repository }}" ]]; then + if [[ "$EVENT_NAME" == "pull_request" && \ + "$HEAD_REPO_FULL_NAME" != "$REPOSITORY" ]]; thenActions-by-SHA pinning (also flagged as hardening) is intentionally out of scope here — it touches every workflow in the repo and is best done in a dedicated pass.
Evidence
No behavior change: same fork-check logic, same
fork-prefix output.Merge Danger
Door: two-way (revert the commit)
Blast Radius: CI-only