Configurable default window dimensions - #1828
Draft
felipeerias wants to merge 1 commit into
Draft
Conversation
Define the preset window dimensions at build time. Unfortunately, Gradle doesn't allow us to define complex data structures and there isn't a clean way to access dimension resources from static constants and enums, which means that each dimension is defined as a separate constant. The default size is WINDOW_PRESET_0_WIDTH by WINDOW_PRESET_0_HEIGHT. We also define the DEFAULT_LOGICAL_WIDTH in CSS pixels. This value, along witht he density and the width of the default window are used to calculate the DPI. This provides a configurable and predictable way of defining the default window size, logical size, and texture size, for different builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Define the preset window dimensions at build time.
Unfortunately, Gradle doesn't allow us to define complex data structures and there isn't a clean way to access dimension resources from static constants and enums, which means that each dimension is defined as a separate constant.
The default size is WINDOW_PRESET_0_WIDTH by WINDOW_PRESET_0_HEIGHT.
We also define the DEFAULT_LOGICAL_WIDTH in CSS pixels. This value, along witht he density and the width of the default window are used to calculate the DPI.
This provides a configurable and predictable way of defining the default window size, logical size, and texture size, for different builds.