Skip to content

Chromium: Make password saving option independent from autofill option in Privacy settings #1738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
haanhvu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Chromium: Make password saving option independent from autofill option in Privacy settings #1738

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion app/src/common/chromium/com/igalia/wolvic/browser/api/impl/PromptDelegateImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -958,6 +958,8 @@ public class AutocompleteBridge implements PasswordManager.Bridge, AutofillManag
private LoginSavePrompt mLoginSavePrompt;
private LoginSelectPrompt mLoginSelectPrompt;

private boolean showLoginSelectPrompt;

public void setListener(PasswordManager.Listener listener) {
mPasswordManagerListener = listener;
}
Expand All @@ -973,7 +975,11 @@ public boolean isAutocompleteEnabled(Context context) {

@Override
public boolean isAutoFillEnabled(Context context) {
return SettingsStore.getInstance(context).isAutoFillEnabled();
// Chromium doesn't provide an autofill option.
// Instead, it provides a login selection prompt that let users decide whether to autofill the saved password or not.
// We'll only show this prompt if users enable autofill.
showLoginSelectPrompt = SettingsStore.getInstance(context).isAutoFillEnabled();
return true;
Comment thread
svillar marked this conversation as resolved.
}

@Override
Expand Down Expand Up @@ -1011,6 +1017,10 @@ public boolean saveOrUpdatePassword(PasswordForm form) {

@Override
public boolean onLoginSelect(PasswordForm[] forms) {
if (!showLoginSelectPrompt) {
return false;
}

dismiss();
assert mPasswordManagerListener != null;

Expand Down Expand Up @@ -1038,6 +1048,10 @@ public boolean onLoginSelect(PasswordForm[] forms) {

@Override
public boolean onLoginSelect(String[] username) {
if (!showLoginSelectPrompt) {
return false;
}

dismiss();
assert mAutofillManagerListener != null;

Expand Down