fix(stream): frame guard verdict liveness + release upload guard - #2
Merged
Conversation
The frame guard could keep a tab 'pending' forever: setTimeout can fire up to 1 ms early (libuv rounds to ms), so the settle timer's own callback landed with the window not quite expired, cleared itself, and nothing re-armed it. Every subframe was covered yet the iframes stayed hidden for the whole stream. Not a leak (it fails closed), but the page is broken. evaluateNow now always re-schedules when the verdict hangs on the settle window alone. Reproduced 1 in 15 runs on a loaded single core; 0 in 45 after the fix. release.yml: electron-builder silently SKIPS uploading into a published release when it is configured to publish drafts, so the whole run went green with zero assets attached. The draft job now fails loudly on a hand-created release, and a new verify job asserts every installer plus the three latest*.yml are attached.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The frame guard could keep a tab 'pending' forever: setTimeout can fire up to 1 ms early (libuv rounds to ms), so the settle timer's own callback landed with the window not quite expired, cleared itself, and nothing re-armed it. Every subframe was covered yet the iframes stayed hidden for the whole stream. Not a leak (it fails closed), but the page is broken. evaluateNow now always re-schedules when the verdict hangs on the settle window alone. Reproduced 1 in 15 runs on a loaded single core; 0 in 45 after the fix.
release.yml: electron-builder silently SKIPS uploading into a published release when it is configured to publish drafts, so the whole run went green with zero assets attached. The draft job now fails loudly on a hand-created release, and a new verify job asserts every installer plus the three latest*.yml are attached.