Skip to content

nanoarrow: add IPC feature - #297287

Open
paleolimbot wants to merge 1 commit into
Homebrew:mainfrom
paleolimbot:nanoarrow-0-9-0-ipc
Open

nanoarrow: add IPC feature#297287
paleolimbot wants to merge 1 commit into
Homebrew:mainfrom
paleolimbot:nanoarrow-0-9-0-ipc

Conversation

@paleolimbot

@paleolimbot paleolimbot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>?
  • Is your test running fine brew test <formula>?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

  • I did not use AI/LLM to create this PR, or I disclosed the tool/model below and reviewed its output; I did not attribute commits to AI and will answer maintainer questions and review comments myself without AI/LLM.

Copilot via Claude Opus 4.5 helped me with the additions. I'm happy to answer questions about this (I'm a nanoarrow maintainer).


@github-actions github-actions Bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Aug 5, 2026
@paleolimbot
paleolimbot force-pushed the nanoarrow-0-9-0-ipc branch from 0560940 to 6820e67 Compare August 5, 2026 17:58
@github-actions github-actions Bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Aug 5, 2026
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Thanks for contributing to Homebrew! 馃帀 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@github-actions github-actions Bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Aug 6, 2026
@paleolimbot
paleolimbot force-pushed the nanoarrow-0-9-0-ipc branch from 21a4721 to 2a08430 Compare August 6, 2026 12:26
@github-actions github-actions Bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Aug 6, 2026
@paleolimbot
paleolimbot force-pushed the nanoarrow-0-9-0-ipc branch from d71fe74 to 5a078c1 Compare August 6, 2026 17:18
@daeho-ro daeho-ro changed the title Add IPC feature to nanoarrow formula nanoarrow: add IPC feature Aug 7, 2026
@paleolimbot
paleolimbot force-pushed the nanoarrow-0-9-0-ipc branch from 5a078c1 to 1af4f4b Compare August 7, 2026 14:13
Comment thread Formula/n/nanoarrow.rb Outdated
def install
system "cmake", "-S", ".", "-B", "build", *std_cmake_args
args = %w[-DNANOARROW_IPC=ON]
args << "-DNANOARROW_FLATCC_ROOT_DIR=#{Formula["flatcc"].opt_prefix}"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
args << "-DNANOARROW_FLATCC_ROOT_DIR=#{Formula["flatcc"].opt_prefix}"
args << "-DNANOARROW_FLATCC_ROOT_DIR=#{formula_opt_prefix("flatcc")}"

@paleolimbot
paleolimbot force-pushed the nanoarrow-0-9-0-ipc branch 2 times, most recently from 58b32e1 to ac5453a Compare August 7, 2026 15:30
@github-actions github-actions Bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Aug 7, 2026
@paleolimbot
paleolimbot force-pushed the nanoarrow-0-9-0-ipc branch 2 times, most recently from cb1ab0e to 7e4ef03 Compare August 7, 2026 17:02
@github-actions github-actions Bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Aug 7, 2026
@paleolimbot
paleolimbot marked this pull request as ready for review August 7, 2026 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants