Make sender nullable to handle non-player audiences gracefully. - #822
Open
Zoriot wants to merge 1 commit into
Open
Make sender nullable to handle non-player audiences gracefully.#822Zoriot wants to merge 1 commit into
Zoriot wants to merge 1 commit into
Conversation
With these changes placeholder in formats coming from console are now supported.
We might want a better way for setting a Console Prefix but you can now do a thing like %changeoutput_equals_input:{luckperms_prefix}_matcher:_ifmatch:<red>Console</red>_else:{luckperms_prefix}% in the format and it's resolved correctly.
Requested/asked on Discord.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With these changes' placeholder in formats coming from console are now supported. We might want a better way for setting a Console Prefix, but you can now do a thing like
%changeoutput_equals_input:{luckperms_prefix}_matcher:_ifmatch:<red>Console</red>_else:{luckperms_prefix}%in the format, and it's resolved correctly.Requested/asked on Discord.