Fixing the work of quickPrefix - #816
Open
HarvelsX wants to merge 1 commit into
Open
Conversation
HarvelsX
force-pushed
the
trunk
branch
2 times, most recently
from
July 13, 2026 11:14
4a968e6 to
3d399dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logic for replacing
quickPrefixhas been moved fromchannelForMessagetoChatListenerInternalto prevent the prefix from being replaced twice when a channel is received inonPaperChatDecorate.Why does
channelForMessagemodify the message and return aChannelMessageat all, rather than just aChatChannel? I couldn’t think of an elegant way to apply this to the general API, so I left it as it is for a quick fix.