Repository navigation
fix(build): don't fail a pushed build when the cache trace finds no cache lines - #28
Merged
Merged
Conversation
…ache lines The cache trace greps the buildx log for cache lines. Under set -e -o pipefail grep exits 1 when none match, so a build whose image was already pushed was reported as failed and finalize (merge + tag + deploy) was skipped. The trace is informational, so it must not decide the job result.
beeinger
approved these changes
Oct 21, 2026
beeinger
left a comment
Member
There was a problem hiding this comment.
Correct — the trace grep runs inside build_one under set -e, and a no-match exit aborts the worker after the push already succeeded. This broke daloc-frontend-new deploys today (1.0.57 arm64 pushed, deploy skipped). Merging to unblock; the informational trace survives via the || true.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
build_images.shends each build with a cache trace (added in 7b3f2fb):The script runs with
set -e -o pipefail. When the buildx log has no line mentioning the cache,grepexits 1,build_onereturns 1, and the job reportsBuild failed for <app>even though the image was built and pushed.finalize (merge + tag + deploy)is then skipped.Seen in
HerodotusDev/daloc-frontend-newrun 39594663856 (release 1.0.57): both…-arm64and…-amd64logged✅ pushed, thenBuild failed, and nothing was deployed.Fix
Append
|| trueto the trace'sgrep. The trace is informational, so it must not decide the job result.Notes
build_oneskips images that already exist (⏭ … exists) andfinalizethen runs.type=ghacache backend produced no output on that run, which may be worth a look alongside the smoke probes.