Repository navigation
venue: honor the CoreDepositWallet destinationDex on EVM to Core deposits (0.2.9) - #6
Merged
Merged
Conversation
…sits (0 credits the default perp dex, u32::MAX spot, depositFor credits its recipient)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sim credited every EVM to Core USDC deposit to the spot wallet, ignoring the
destinationDexof the CoreDepositWallet call. On the real venue the simple margin agent'sdepositToCore(amount, 0)(depositFor(.., 0), the default perp dex) lands in the perp balance.deposit/depositForcall from the block's call trace and credits the wallet it names:0the default perp dex,u32::MAXspot, any other index thatperpDexsdex.depositForcredits its recipient.sendfrom spot into that dex in the ledger.Tests: call decoding, trace matching rules, perp credit and ledger row.
cargo test -p diorama-venueand clippy are clean.