feat(jawn): add official Valkey backend support with CI and docs - #5764
Open
rileydes-improving wants to merge 1 commit into
Open
feat(jawn): add official Valkey backend support with CI and docs#5764rileydes-improving wants to merge 1 commit into
rileydes-improving wants to merge 1 commit into
Conversation
- Add integration test validating all Redis command patterns against Valkey - Add GitHub Actions workflow running Jawn tests against valkey - Add self-hosting documentation for Valkey as a supported backend - Zero application code changes, ioredis connects to Valkey transparently Signed-off-by: Riley Desserre <riley.desserre@improving.com>
Contributor
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
|
@rileydes-improving is attempting to deploy a commit to the Helicone Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
#5753
Component/Service
What part of Helicone does this affect?
Type of Change
Deployment Notes
No application code is modified. Operators already on Valkey continue working as-is. Operators on Redis are completely unaffected. For new Valkey adopters, the only change is pointing REDIS_HOST at their Valkey endpoint.
Extra Notes
Context
Helicone's Redis dependency in Jawn works with Valkey transparently (all commands predate the fork), but this compatibility is undocumented, untested in CI, and invisible to operators evaluating Helicone's stack. Two of three closest competitors (LangFuse, LangSmith) already officially support Valkey. This PR adds tests, CI, and documentation confirming what already works.
The five subsystems that touch Redis (KV cache, proxy rate limiter, HTTP API rate limiter, usage-limit cache, encrypted provider key/auth cache) all share a single ioredis client and issue only core Redis commands present since Redis 2.x, all fully supported in Valkey.