fix(ripple): 修复列表第一次点击时不显示涟漪的问题以及滚动时仍然保持涟漪的问题 - #6709
Conversation
ToobLac
changed the title
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 385afa8aab
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| this.graphic.releaseRippleImmediately(); | ||
| super.updateItem(item, empty); | ||
|
|
||
| if (Objects.equals(oldItem, item) && oldEmpty == empty) return; |
There was a problem hiding this comment.
When Java discovery is refreshed after a JDK is upgraded or replaced in place, the cell receives a new JavaRuntime whose version, vendor, architecture, JDK status, or managed status may differ, but JavaRuntime.equals compares only the binary path. This return therefore leaves the old labels, tags, and remove action visible even though getItem() now points to the new runtime; use identity or otherwise continue updating when equal objects are distinct.
Useful? React with 👍 / 👎.
2 participants
Fixes #6703