清理 Lang - #6707
Open
CiiLu wants to merge 1 commit into
Open
Conversation
CiiLu
marked this pull request as draft
August 18, 2026 12:06
CiiLu
marked this pull request as ready for review
August 18, 2026 12:13
Glavo
requested changes
Aug 19, 2026
| JavaVersionType javaVersionType = setting.getInheritable(GameSettings::javaTypeProperty); | ||
| if (setting.getInheritable(GameSettings::notCheckJVMProperty)) { | ||
| task = getJavaTask.thenApplyAsync(java -> Lang.requireNonNullElse(java, JavaRuntime.getDefault())); | ||
| task = getJavaTask.thenApplyAsync(java -> Objects.requireNonNullElse(java, JavaRuntime.getDefault())); |
Member
There was a problem hiding this comment.
这里不能用 Objects.requireNonNullElse。
| } | ||
|
|
||
| installable.bind(Bindings.createBooleanBinding(() -> compatible.get() && txtName.validate(), txtName.textProperty(), compatible)); | ||
| installable.bind(Bindings.createBooleanBinding(() -> compatible.get() && txtName.validate(), txtName.textProperty(), compatible)); |
| String libraryId = library.getLibraryId(); | ||
| String version = analyzer.getVersion(libraryId).orElse(null); | ||
| String libraryVersion = Lang.requireNonNullElse(getVersion(libraryId), version); | ||
| String libraryVersion = Objects.requireNonNullElse(getVersion(libraryId), version); |
Member
There was a problem hiding this comment.
这里不能使用 Objects.requireNonNullElse。
Comment on lines
+303
to
+306
| mainClass = Objects.requireNonNullElse(mainClass, patch.getMainClass()); | ||
| assetIndex = Objects.requireNonNullElse(patch.getAssetIndex(), assetIndex); | ||
| javaMajors = Objects.requireNonNullElse(patch.getJavaMajors(), javaMajors); | ||
| mainJar = Objects.requireNonNullElse(patch.getMainJar(), mainJar); |
Member
There was a problem hiding this comment.
这些地方不能用 Objects.requireNonNullElse
| if (!existed.containsKey(componentID)) { | ||
| Task<MultiMCInstancePatch> task = new GetTask(MultiMCComponents.getMetaURL( | ||
| componentID, Lang.requireNonNullElse(require.getEqualsVersion(), require.getSuggests()), mcVersion | ||
| componentID, Objects.requireNonNullElse(require.getEqualsVersion(), require.getSuggests()), mcVersion |
Member
There was a problem hiding this comment.
这里不能用 Objects.requireNonNullElse。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.