Skip to content

清理未使用 i18n 键值 - #6688

Open
CiiLu wants to merge 6 commits into
HMCL-dev:mainfrom
CiiLu:tare/agent-solo-qwq
Open

清理未使用 i18n 键值#6688
CiiLu wants to merge 6 commits into
HMCL-dev:mainfrom
CiiLu:tare/agent-solo-qwq

Conversation

@CiiLu

@CiiLu CiiLu commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added the 1+ label Aug 15, 2026
@Glavo

Glavo commented Aug 19, 2026

Copy link
Copy Markdown
Member

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 69b7a44e98

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@@ -1190,12 +1153,6 @@ modrinth.category.velocity=Velocity
modrinth.category.waterfall=Waterfall
modrinth.category.worldgen=Worldgen
modrinth.category.8x-=8x or lower

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restore the Modrinth resolution category keys

When the Modrinth resource-pack category list contains any of the still-supported 16x through 256x resolutions, DownloadListPage.getLocalizedCategory constructs modrinth.category.<category> dynamically. Removing these six keys from every bundle makes SupportedLocale.i18n log a missing-resource error and display the raw key (for example, modrinth.category.64x) in the category selector, while the adjacent 8x- and 512x+ categories remain localized.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants