Add streaming support - #57
Open
bglusman wants to merge 3 commits into
Open
Conversation
bglusman
commented
Feb 7, 2025
| defp build_pipeline(request, opts) do | ||
| disable_polling = Keyword.fetch!(opts, :async) | ||
| async? = Keyword.fetch!(opts, :async) | ||
| streaming? = Keyword.get(opts, :streaming, false) |
Author
There was a problem hiding this comment.
hmm should this ALSO be fetch! because of how NimbleOptions will build opts and take care of the default value I guess?
bglusman
commented
Feb 7, 2025
Comment on lines
+62
to
+66
| Enum.zip_reduce(types, row, %{}, fn type, value, result -> | ||
| column_name = maybe_downcased_column_name(type, downcase_column_names) | ||
| column_value = decode(type, value) | ||
| Map.put(result, column_name, column_value) | ||
| end) |
Author
There was a problem hiding this comment.
we could DRY this up with the above function head of decode_data_rows
Collaborator
|
@aschreifels FYI. Not sure how much the team is investing in SF these days, but this is the start of a decent feature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIrst pass at resolving #51 I opened quite a while back now, to be totally frank Claude wrote a lot of this code via Cursor or Windsurf, but I definitely participated a fair bit 🤣 I think it at least serves as a good start as it seems to work and preserve all the old behavior/passes the old tests and the new ones... I'm not totally sure about the async interaction/didn't test that exlicitly, so maybe someone who knows the code around async can have a look/suggest some test or concerns around interactions there? 🤷♂️
cc @forest since we discussed last year and @vuphamcs since he reacted there, expressing some interest... maybe of interest to @pdgonzalez872 also and @jeremyowensboggs since I discussed with him/may have been his idea originally...