Repository navigation
March dollase - #2065
Merged
Merged
March dollase#2065
Conversation
Use RefineTexture whenever harmonic coefficients vary (hexrd now skips March-Dollase models there), since Refine() never moves them. Clear stale texture data on any non-harmonic run, skip empty texture tree nodes, and update the test to the new settings layout. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
psavery
approved these changes
Oct 6, 2026
Refine P_MD through the runner on a simulated pattern and check the label and undo. Also reword the validation for harmonic coefficients, since P_MD is a texture parameter too. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes March-Dollase texture function. This is in preparation for the paper submission.
Fixes: #2061