Fix WPPF phase fraction handling - #2062
Merged
Merged
Conversation
Regenerate phase fractions when the phases change (adding one pinned the new phase at zero), lock their bounds, skip them for delta boundaries, show the remainder's uncertainty, and validate them before running. This uses hexrd's new stick_breaking module, so merge the hexrd change first. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
Display and edit phase fractions in percent (value, bounds, and uncertainty) in the WPPF tree view, while the parameters stay 0-1. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regenerate phase fractions when the phases change (adding one pinned the new phase at zero), lock their bounds, skip them for delta boundaries, show the remainder's uncertainty, and validate them before running. This uses hexrd's new stick_breaking module, so merge the hexrd change first.
Depends on: HEXRD/hexrd#983