Skip to content

Refine customer intake form UX, accessibility, and action bar - #60

Merged
H2OKing89 merged 4 commits into
masterfrom
feedback
Nov 2, 2026
Merged

H2OKing89 merged 4 commits into
masterfrom
feedback

Conversation

@H2OKing89

@H2OKing89 H2OKing89 commented Nov 2, 2026 •

Copy link
Copy Markdown
Owner

Overview

Improves the customer intake screen layout, accessibility, and overall user experience by streamlining form labels, enhancing QR code functionality, and refactoring the bottom action buttons into a dedicated action bar component.

Key Changes

  • UX and Form Improvements:

    • Clarifies required versus optional fields by adding a general required section indicator and updating field labels and supporting texts.
    • Refines icon styles, touch targets, and padding across the screen layout for better consistency and readability.
  • QR Code Section:

    • Integrates and relocates the QR code generation options directly into the form layout with improved hint messaging and preview support.
  • Component Refactoring:

    • Extracts the persistent message actions into a standalone action bar component to improve structure, maintainability, and layout responsiveness.
  • Testing & Accessibility:

    • Updates UI test matchers and semantics to properly align with the new label structures and enhanced content descriptions.

Summary by CodeRabbit

  • New Features
    • Added a QR code option within the customer intake form, with guidance based on the network details entered.
    • Updated the bottom action area with clearer Share and Copy controls. Copy now confirms success with a checkmark and “Copied” label.
  • Improvements
    • Refined the intake screen layout and button sizing for easier use across screen sizes and with larger text.
    • Clarified field labels and guidance, including required-field indicators and phone-number help text.

Improves the customer intake screen form layout and accessibility by updating field labels, clarifying optional/required fields, and adjusting UI text for consistency.

- Adds a general required fields indicator to the section header
- Streamlines field label formatting to integrate required markers
- Updates various form labels and helper texts for better clarity
- Adjusts UI test matchers to support updated label structures
… component for improved structure and readability
@coderabbitai

coderabbitai Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Essentials
  • Run ID: f5cb31ab-5fce-4bca-adf6-69312886561e
Commits

Reviewing files that changed from the base of the PR and between a2f5595 and b514344.

Files selected for processing: 10
  • app/src/androidTest/java/com/kingpaging/qwelcome/ui/CustomerIntakeScreenTest.kt
  • app/src/androidTest/java/com/kingpaging/qwelcome/ui/CustomerIntakeSecurityTest.kt
  • app/src/main/java/com/kingpaging/qwelcome/ui/CustomerIntakeActionButtonRow.kt
  • app/src/main/java/com/kingpaging/qwelcome/ui/CustomerIntakeFormFields.kt
  • app/src/main/java/com/kingpaging/qwelcome/ui/CustomerIntakeQrCodeSection.kt
  • app/src/main/java/com/kingpaging/qwelcome/ui/CustomerIntakeScreen.kt
  • app/src/main/java/com/kingpaging/qwelcome/ui/components/CenteredFormColumn.kt
  • app/src/main/java/com/kingpaging/qwelcome/ui/components/GradientHeader.kt
  • app/src/main/res/values/strings.xml
  • app/src/main/res/values/strings_intake_ux.xml

Included review availability: This review used your included allowance. 4 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

Walkthrough

The customer intake UI now uses revised field labels and required-field semantics, displays QR controls within the Wi-Fi form, and uses a redesigned action bar. The screen layout, header accessibility semantics, and related tests and previews were also updated.

Changes: Customer intake UI

Layer / File(s) Summary
Field labels and semantics
app/src/main/java/com/kingpaging/qwelcome/ui/CustomerIntakeFormFields.kt, app/src/main/res/values/strings.xml, app/src/main/res/values/strings_intake_ux.xml, app/src/androidTest/java/com/kingpaging/qwelcome/ui/CustomerIntakeScreenTest.kt
Field labels and phone guidance were revised. Required labels now show an asterisk and expose required status through semantics. The shared editable-field matcher now matches label text as a substring.
QR controls in the Wi-Fi form
app/src/main/java/com/kingpaging/qwelcome/ui/CustomerIntakeFormFields.kt, app/src/main/java/com/kingpaging/qwelcome/ui/CustomerIntakeQrCodeSection.kt, app/src/main/java/com/kingpaging/qwelcome/ui/CustomerIntakeScreen.kt, app/src/main/res/values/strings.xml, app/src/main/res/values/strings_intake_ux.xml, app/src/androidTest/java/com/kingpaging/qwelcome/ui/CustomerIntakeSecurityTest.kt
The QR section moved into the Wi-Fi form and receives the UI state, enabled state, and callback. The section uses a wrapping layout and displays hints only when disabled. QR labels and hint text were updated.
Screen layout and action bar
app/src/main/java/com/kingpaging/qwelcome/ui/CustomerIntakeActionButtonRow.kt, app/src/main/java/com/kingpaging/qwelcome/ui/CustomerIntakeScreen.kt, app/src/main/java/com/kingpaging/qwelcome/ui/components/CenteredFormColumn.kt, app/src/main/java/com/kingpaging/qwelcome/ui/components/GradientHeader.kt, app/src/main/res/values/strings_intake_ux.xml
The action row became CustomerIntakeActionBar, with a surface, divider, responsive button layout, and updated Copy success state. The screen uses revised touch targets and configurable form padding. The header now uses grouped accessibility semantics and the “Welcome” title.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Possibly related PRs

  • H2OKing89/QWelcome#57: Adds QR validation and handling that connect to the QR controls integrated into the intake form here.
  • H2OKing89/QWelcome#59: Updates the same intake screen, form fields, action bar, and QR UI.
Merge Risk: Minimal · up to b5143

No actionable merge-blocking risk remains from the reviewed changes.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly summarizes the main changes to customer intake UX, accessibility, and the action bar.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 3 functions across 8 files. (2 skipped: 2 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Finishing Touches
Generate docstrings
  • Commit to this branch
  • Create a new PR
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

The form now marks each required name,
Wi-Fi QR hints have changed their game.
The action bar wraps buttons with care,
A clearer header greets you there.
I pity the fool who misses that!

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-02T02:57:37.603137Z b514344 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@H2OKing89
H2OKing89 merged commit 041ee5c into master Nov 2, 2026
2 of 10 checks passed
@H2OKing89
H2OKing89 deleted the feedback branch November 2, 2026 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant