Repository navigation
release: v2.7.3 - #39
Conversation
📝 WalkthroughWalkthroughRelease version bump (2.7.3) bundling comprehensive TemplateEditorScreen UI test suite, migration of clipboard operations from system Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Rationale: Mixed complexity across multiple change patterns—comprehensive new test suite requires careful verification of assertion correctness and edge-case coverage; clipboard migration involves three files with distinct logic paths requiring validation of exception handling and state management; deprecation refactoring is lower-risk cleanup; manifest and version updates are trivial. Moderate file spread with some heterogeneity in change types. Possibly related PRs
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ff44d89c83
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| // Dialog should be gone, editor still visible | ||
| composeRule.onNodeWithText(appContext.getString(R.string.dialog_discard_changes_title)) | ||
| .assertDoesNotExist() |
There was a problem hiding this comment.
Import assertDoesNotExist before invoking it
This file calls assertDoesNotExist() in multiple tests, but androidx.compose.ui.test.assertDoesNotExist is never imported, unlike the other Compose assertion extensions at the top of the file. In Kotlin, these are extension functions that must be imported, so :app:compileDebugAndroidTestKotlin will fail with an unresolved reference and the newly added instrumentation tests cannot run.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@app/src/androidTest/java/com/kingpaging/qwelcome/ui/templates/TemplateEditorScreenTest.kt`:
- Around line 4-18: The test file uses the infix operator "and" and the
assertion "assertDoesNotExist" but they are not imported, causing unresolved
references; fix this by adding the missing imports
androidx.compose.ui.test.assertDoesNotExist and androidx.compose.ui.test.and to
the import block in TemplateEditorScreenTest (where other
androidx.compose.ui.test imports like onNodeWithText and performClick live) so
the uses of assertDoesNotExist and the infix and compile.
In `@CHANGELOG.md`:
- Around line 14-17: The MD022 lint failures are caused by missing blank lines
after markdown headings; update the CHANGELOG.md by inserting a single blank
line after each heading instance (e.g., after the "### Added" and "### Changed"
headings shown and any other headings around lines referenced like the one near
"### ..." at line ~27) so that every heading is followed by one empty line, then
re-run markdownlint to verify MD022 is resolved.
- Around line 18-29: Update the CHANGELOG.md dependency versions to exactly
match gradle/libs.versions.toml (set Kotlin to 2.2.10, Compose BOM to
2026.01.00, AGP to 9.1.0, Navigation Compose to 2.9.0, Firebase BOM to 34.8.0,
Protobuf to 3.25.5) and change the "clipboard migration" note from "migrated to
modern `LocalClipboard` APIs" to state it's partial/in-progress (or
alternatively finish the migration); specifically audit Navigator.kt and
ExportScreen.kt which still use deprecated ClipboardManager/CLIPBOARD_SERVICE
and either migrate them to LocalClipboardManager (as in ImportScreen.kt) or
explicitly note they remain pending, then grep the repo for ClipboardManager and
CLIPBOARD_SERVICE to confirm all usages before updating the release notes.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: fccf5cfe-6f6d-47c6-9bde-f39db5c3b5e1
📒 Files selected for processing (3)
CHANGELOG.mdapp/src/androidTest/java/com/kingpaging/qwelcome/ui/templates/TemplateEditorScreenTest.ktversion.properties
| - **Dependency Updates** - Updated various core dependencies to their latest stable versions for 2026: | ||
| - Kotlin 2.3.20 | ||
| - Compose BOM 2026.03.01 | ||
| - Android Gradle Plugin 9.1.1 | ||
| - Navigation Compose 2.9.7 | ||
| - Firebase BOM 34.12.0 | ||
| - Protobuf 4.34.1 | ||
| - **Gradle 10 Compatibility** - Resolved various deprecation warnings including multi-string dependency notation in the proto module and deprecated ClipboardManager APIs. | ||
|
|
||
| ### Fixed | ||
| - **Code Quality Cleanup** - Fixed multiple Kotlin compiler warnings, removed unnecessary non-null assertions, and migrated to modern `LocalClipboard` APIs. | ||
|
|
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== Declared dependency versions =="
rg -n '^(agp|kotlin|composeBom|navigationCompose|firebaseBom|protobuf)\s*=' gradle/libs.versions.toml
echo
echo "== Clipboard API usage still present =="
rg -n 'ClipboardManager|CLIPBOARD_SERVICE|LocalClipboardManager' \
app/src/main/java/com/kingpaging/qwelcome/navigation/Navigator.kt \
app/src/main/java/com/kingpaging/qwelcome/ui/export/ExportScreen.kt \
app/src/main/java/com/kingpaging/qwelcome/ui/import_pkg/ImportScreen.ktRepository: H2OKing89/QWelcome
Length of output: 1309
CHANGELOG dependency versions and clipboard migration status do not match actual codebase.
- Issue: Lines 19-24 list incorrect versions. Actual values in
gradle/libs.versions.toml: Kotlin 2.2.10 (not 2.3.20), Compose BOM 2026.01.00 (not 2026.03.01), AGP 9.1.0 (not 9.1.1), Navigation Compose 2.9.0 (not 2.9.7), Firebase BOM 34.8.0 (not 34.12.0), Protobuf 3.25.5 (not 4.34.1). Line 25-28 claim complete clipboard migration, butNavigator.ktandExportScreen.ktstill use deprecatedClipboardManagerandCLIPBOARD_SERVICE; onlyImportScreen.kthas migrated toLocalClipboardManager. - Impact: Published release notes will be factually incorrect, misleading users and downstream maintainers about what's actually in the release.
- Fix: Update all version numbers to match
gradle/libs.versions.toml. Reword clipboard migration as partial/in-progress, or complete the migration before release. - Test: Scan version declarations and grep clipboard API usage across codebase before publishing.
🧰 Tools
🪛 markdownlint-cli2 (0.22.0)
[warning] 27-27: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@CHANGELOG.md` around lines 18 - 29, Update the CHANGELOG.md dependency
versions to exactly match gradle/libs.versions.toml (set Kotlin to 2.2.10,
Compose BOM to 2026.01.00, AGP to 9.1.0, Navigation Compose to 2.9.0, Firebase
BOM to 34.8.0, Protobuf to 3.25.5) and change the "clipboard migration" note
from "migrated to modern `LocalClipboard` APIs" to state it's
partial/in-progress (or alternatively finish the migration); specifically audit
Navigator.kt and ExportScreen.kt which still use deprecated
ClipboardManager/CLIPBOARD_SERVICE and either migrate them to
LocalClipboardManager (as in ImportScreen.kt) or explicitly note they remain
pending, then grep the repo for ClipboardManager and CLIPBOARD_SERVICE to
confirm all usages before updating the release notes.
- Fixed missing imports in TemplateEditorScreenTest - Resolved CHANGELOG.md lint failures (MD022) - Completed LocalClipboard migration in ExportScreen.kt - Clarified clipboard migration status in CHANGELOG.md
- [TemplateEditorScreen] fix nullable format argument in stringResource - [ExportModels] remove redundant inner deprecation suppressions - [ImportScreen] safe clipboard extraction and blank handling - [AndroidManifest] add ACTION_VIEW query for APK installer compatibility
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@scripts/bump-version.ps1`:
- Around line 13-14: The PowerShell script scripts/bump-version.ps1 contains
non-ASCII glyphs but lacks a UTF-8 BOM; re-save or encode
scripts/bump-version.ps1 with UTF-8 + BOM (prefix EF BB BF) so PowerShell
correctly interprets box-drawing characters and symbols, or alternatively
replace the non-ASCII glyphs with ASCII equivalents throughout; after saving,
verify the file begins with EF BB BF in hex and re-run PSScriptAnalyzer to
confirm PSUseBOMForUnicodeEncodedFile passes.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 4b307138-4ac2-46a3-9639-5f9699855557
📒 Files selected for processing (13)
CHANGELOG.mdapp/src/androidTest/java/com/kingpaging/qwelcome/ui/templates/TemplateEditorScreenTest.ktapp/src/main/java/com/kingpaging/qwelcome/data/ExportModels.ktapp/src/main/java/com/kingpaging/qwelcome/data/GitHubAppUpdater.ktapp/src/main/java/com/kingpaging/qwelcome/ui/components/TemplateVariablesSheet.ktapp/src/main/java/com/kingpaging/qwelcome/ui/export/ExportScreen.ktapp/src/main/java/com/kingpaging/qwelcome/ui/import_pkg/ImportScreen.ktapp/src/main/java/com/kingpaging/qwelcome/ui/templates/TemplateEditorScreen.ktapp/src/main/java/com/kingpaging/qwelcome/ui/templates/TemplateListScreen.ktapp/src/main/res/values/strings.xmlgradle/libs.versions.tomlproto/build.gradle.ktsscripts/bump-version.ps1
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@app/src/main/java/com/kingpaging/qwelcome/ui/import_pkg/ImportScreen.kt`:
- Around line 204-227: The clipboard handling currently calls
entry.clipData.getItemAt(0) without checking itemCount, which can throw
IndexOutOfBounds; update the block that starts with
clipboardManager.getClipEntry() to first check entry.clipData?.itemCount ?: 0 >
0 before calling getItemAt(0), and if itemCount is 0, run the existing
empty-clipboard path (soundPlayer.playBeep() + Toast for
R.string.toast_clipboard_empty) instead of attempting to access the item; keep
the existing flow for non-empty clips (extract text, use
exceedsImportLimit(...), call vm.onPasteContent(...) or show the "too large"
toast).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 30cc8d66-0b5e-4ccb-a50e-3c2771a2cc98
📒 Files selected for processing (4)
app/src/main/AndroidManifest.xmlapp/src/main/java/com/kingpaging/qwelcome/data/ExportModels.ktapp/src/main/java/com/kingpaging/qwelcome/ui/import_pkg/ImportScreen.ktapp/src/main/java/com/kingpaging/qwelcome/ui/templates/TemplateEditorScreen.kt
Release v2.7.3
Summary
This release includes the new UI tests for the Template Editor, several dependency updates to latest stable versions, and a series of bug fixes and code quality improvements to resolve all outstanding compilation and lint warnings.
Changes
[2.7.3] - 2026-04-18
Added
Changed
Fixed
Files Changed
Type of Change
Testing
Checklist
Summary by CodeRabbit
New Features
Bug Fixes
Chores