Skip to content

release: v2.7.3 - #39

Merged
H2OKing89 merged 5 commits into
masterfrom
release/v2.7.3
Apr 19, 2026
Merged

H2OKing89 merged 5 commits into
masterfrom
release/v2.7.3

Conversation

@H2OKing89

@H2OKing89 H2OKing89 commented Apr 18, 2026 •

Copy link
Copy Markdown
Owner

Release v2.7.3

Summary

This release includes the new UI tests for the Template Editor, several dependency updates to latest stable versions, and a series of bug fixes and code quality improvements to resolve all outstanding compilation and lint warnings.

Changes

[2.7.3] - 2026-04-18

Added

  • UI Tests for Template Editor - Added comprehensive automated UI tests for the Template Editor screen ensuring reliable validation, character limit handling, and discard dialog behavior.

Changed

  • Dependency Updates - Updated various core dependencies to their latest stable versions for 2026:
    • Kotlin 2.3.20
    • Compose BOM 2026.03.01
    • Android Gradle Plugin 9.1.1
    • Navigation Compose 2.9.7
    • Firebase BOM 34.12.0
    • Protobuf 4.34.1
  • Gradle 10 Compatibility - Resolved various deprecation warnings including multi-string dependency notation in the proto module and deprecated ClipboardManager APIs.

Fixed

  • Code Quality Cleanup - Fixed multiple Kotlin compiler warnings, removed unnecessary non-null assertions, and migrated to modern LocalClipboard APIs.

Files Changed

  • data/: ExportModels.kt, GitHubAppUpdater.kt
  • ui/: TemplateVariablesSheet.kt, ImportScreen.kt, TemplateEditorScreen.kt, TemplateListScreen.kt
  • res/: strings.xml
  • gradle/: libs.versions.toml, version.properties

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Testing

  • ./gradlew test passes
  • ./gradlew lintDebug passes
  • Verified dark mode
  • Verified light mode

Checklist

  • Changelog entries are complete and accurate
  • version.properties updated (VERSION_NAME=2.7.3, VERSION_CODE=16)
  • All CI checks pass
  • APK builds successfully

Summary by CodeRabbit

  • New Features

    • Expanded Template Editor UI test coverage for validation, character limits, and unsaved-changes dialogs.
  • Bug Fixes

    • Updated clipboard handling to use modern Compose APIs.
    • Resolved deprecated API usage and cleaned up compiler warnings.
  • Chores

    • Bumped version to 2.7.3 (code 16).
    • Updated core dependency versions (Kotlin, Compose BOM, Android Gradle Plugin, Firebase BOM, Navigation Compose, Protobuf).
    • Added manifest query support for APK file handling.

@coderabbitai

coderabbitai Bot commented Apr 18, 2026 •

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

Release version bump (2.7.3) bundling comprehensive TemplateEditorScreen UI test suite, migration of clipboard operations from system ClipboardManager to Compose LocalClipboard APIs, refactoring of deprecation suppressions, dependency version updates in changelog, APK intent manifest handling, and minor code cleanup.

Changes

Cohort / File(s) Summary
UI Test Suite
app/src/androidTest/java/com/kingpaging/qwelcome/ui/templates/TemplateEditorScreenTest.kt
New comprehensive instrumentation test suite (525 lines) covering template creation/editing modes, name field validation and max-length enforcement, tag suggestion and chip management, placeholder validation with error states, content editor dialog interaction, and discard-changes dialog behavior on cancel.
Clipboard Migration
app/src/main/java/com/kingpaging/qwelcome/ui/export/ExportScreen.kt, app/src/main/java/com/kingpaging/qwelcome/ui/import_pkg/ImportScreen.kt
Replaced system ClipboardManager with Compose LocalClipboard API; updated copy/paste handlers to use ClipEntry and getClipEntry() with explicit blank-text handling and exception safety.
Deprecation Refactoring
app/src/main/java/com/kingpaging/qwelcome/data/ExportModels.kt
Moved @Suppress("DEPRECATION") annotations from local expression-level to method-level declarations in TemplatePack.getEffectiveDefaultTemplateId() and FullBackup.getEffectiveDefaultTemplateId() for cleaner code organization.
Template Editor Refinement
app/src/main/java/com/kingpaging/qwelcome/ui/templates/TemplateEditorScreen.kt
Updated ContentEditorField supporting text condition to directly reference contentError != null instead of derived boolean hasContentError.
Release Metadata
version.properties, CHANGELOG.md, scripts/bump-version.ps1
Incremented version from 2.7.2 to 2.7.3 (VERSION_CODE 15→16); added changelog entry documenting template editor UI tests, dependency version updates (Kotlin, Compose BOM, Android Gradle Plugin, Firebase BOM, Protobuf), Gradle 10 deprecation fixes, and code-quality cleanup; normalized punctuation in bump script comments.
Manifest Update
app/src/main/AndroidManifest.xml
Added intent filter entry for android.intent.action.VIEW with content:// data and MIME type application/vnd.android.package-archive (APK file handling).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Rationale: Mixed complexity across multiple change patterns—comprehensive new test suite requires careful verification of assertion correctness and edge-case coverage; clipboard migration involves three files with distinct logic paths requiring validation of exception handling and state management; deprecation refactoring is lower-risk cleanup; manifest and version updates are trivial. Moderate file spread with some heterogeneity in change types.

Possibly related PRs

  • PR #36 — Directly adds the same TemplateEditorScreenTest instrumentation test class with identical test method signatures and coverage patterns.
  • PR #38 — Modifies the same code paths for clipboard API migration and deprecation suppression refactoring across ExportScreen, ImportScreen, and ExportModels.
  • PR #31 — Introduces core TemplateEditorScreen UI component that this PR's test suite comprehensively validates.
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 31.82% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'release: v2.7.3' directly and clearly identifies the primary purpose of the changeset: releasing version 2.7.3 with associated version bumps, changelog updates, new UI tests, and dependency/compatibility fixes.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch release/v2.7.3

Comment @coderabbitai help to get the list of available commands and usage tips.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ff44d89c83

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".


// Dialog should be gone, editor still visible
composeRule.onNodeWithText(appContext.getString(R.string.dialog_discard_changes_title))
.assertDoesNotExist()

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Import assertDoesNotExist before invoking it

This file calls assertDoesNotExist() in multiple tests, but androidx.compose.ui.test.assertDoesNotExist is never imported, unlike the other Compose assertion extensions at the top of the file. In Kotlin, these are extension functions that must be imported, so :app:compileDebugAndroidTestKotlin will fail with an unresolved reference and the newly added instrumentation tests cannot run.

Useful? React with 👍 / 👎.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In
`@app/src/androidTest/java/com/kingpaging/qwelcome/ui/templates/TemplateEditorScreenTest.kt`:
- Around line 4-18: The test file uses the infix operator "and" and the
assertion "assertDoesNotExist" but they are not imported, causing unresolved
references; fix this by adding the missing imports
androidx.compose.ui.test.assertDoesNotExist and androidx.compose.ui.test.and to
the import block in TemplateEditorScreenTest (where other
androidx.compose.ui.test imports like onNodeWithText and performClick live) so
the uses of assertDoesNotExist and the infix and compile.

In `@CHANGELOG.md`:
- Around line 14-17: The MD022 lint failures are caused by missing blank lines
after markdown headings; update the CHANGELOG.md by inserting a single blank
line after each heading instance (e.g., after the "### Added" and "### Changed"
headings shown and any other headings around lines referenced like the one near
"### ..." at line ~27) so that every heading is followed by one empty line, then
re-run markdownlint to verify MD022 is resolved.
- Around line 18-29: Update the CHANGELOG.md dependency versions to exactly
match gradle/libs.versions.toml (set Kotlin to 2.2.10, Compose BOM to
2026.01.00, AGP to 9.1.0, Navigation Compose to 2.9.0, Firebase BOM to 34.8.0,
Protobuf to 3.25.5) and change the "clipboard migration" note from "migrated to
modern `LocalClipboard` APIs" to state it's partial/in-progress (or
alternatively finish the migration); specifically audit Navigator.kt and
ExportScreen.kt which still use deprecated ClipboardManager/CLIPBOARD_SERVICE
and either migrate them to LocalClipboardManager (as in ImportScreen.kt) or
explicitly note they remain pending, then grep the repo for ClipboardManager and
CLIPBOARD_SERVICE to confirm all usages before updating the release notes.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: fccf5cfe-6f6d-47c6-9bde-f39db5c3b5e1

📥 Commits

Reviewing files that changed from the base of the PR and between ef402b1 and ff44d89.

📒 Files selected for processing (3)
  • CHANGELOG.md
  • app/src/androidTest/java/com/kingpaging/qwelcome/ui/templates/TemplateEditorScreenTest.kt
  • version.properties

Comment thread CHANGELOG.md Resolved
Comment thread CHANGELOG.md
Comment on lines +18 to +29
- **Dependency Updates** - Updated various core dependencies to their latest stable versions for 2026:
- Kotlin 2.3.20
- Compose BOM 2026.03.01
- Android Gradle Plugin 9.1.1
- Navigation Compose 2.9.7
- Firebase BOM 34.12.0
- Protobuf 4.34.1
- **Gradle 10 Compatibility** - Resolved various deprecation warnings including multi-string dependency notation in the proto module and deprecated ClipboardManager APIs.

### Fixed
- **Code Quality Cleanup** - Fixed multiple Kotlin compiler warnings, removed unnecessary non-null assertions, and migrated to modern `LocalClipboard` APIs.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== Declared dependency versions =="
rg -n '^(agp|kotlin|composeBom|navigationCompose|firebaseBom|protobuf)\s*=' gradle/libs.versions.toml

echo
echo "== Clipboard API usage still present =="
rg -n 'ClipboardManager|CLIPBOARD_SERVICE|LocalClipboardManager' \
  app/src/main/java/com/kingpaging/qwelcome/navigation/Navigator.kt \
  app/src/main/java/com/kingpaging/qwelcome/ui/export/ExportScreen.kt \
  app/src/main/java/com/kingpaging/qwelcome/ui/import_pkg/ImportScreen.kt

Repository: H2OKing89/QWelcome

Length of output: 1309


CHANGELOG dependency versions and clipboard migration status do not match actual codebase.

  • Issue: Lines 19-24 list incorrect versions. Actual values in gradle/libs.versions.toml: Kotlin 2.2.10 (not 2.3.20), Compose BOM 2026.01.00 (not 2026.03.01), AGP 9.1.0 (not 9.1.1), Navigation Compose 2.9.0 (not 2.9.7), Firebase BOM 34.8.0 (not 34.12.0), Protobuf 3.25.5 (not 4.34.1). Line 25-28 claim complete clipboard migration, but Navigator.kt and ExportScreen.kt still use deprecated ClipboardManager and CLIPBOARD_SERVICE; only ImportScreen.kt has migrated to LocalClipboardManager.
  • Impact: Published release notes will be factually incorrect, misleading users and downstream maintainers about what's actually in the release.
  • Fix: Update all version numbers to match gradle/libs.versions.toml. Reword clipboard migration as partial/in-progress, or complete the migration before release.
  • Test: Scan version declarations and grep clipboard API usage across codebase before publishing.
🧰 Tools
🪛 markdownlint-cli2 (0.22.0)

[warning] 27-27: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below

(MD022, blanks-around-headings)

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@CHANGELOG.md` around lines 18 - 29, Update the CHANGELOG.md dependency
versions to exactly match gradle/libs.versions.toml (set Kotlin to 2.2.10,
Compose BOM to 2026.01.00, AGP to 9.1.0, Navigation Compose to 2.9.0, Firebase
BOM to 34.8.0, Protobuf to 3.25.5) and change the "clipboard migration" note
from "migrated to modern `LocalClipboard` APIs" to state it's
partial/in-progress (or alternatively finish the migration); specifically audit
Navigator.kt and ExportScreen.kt which still use deprecated
ClipboardManager/CLIPBOARD_SERVICE and either migrate them to
LocalClipboardManager (as in ImportScreen.kt) or explicitly note they remain
pending, then grep the repo for ClipboardManager and CLIPBOARD_SERVICE to
confirm all usages before updating the release notes.

- Fixed missing imports in TemplateEditorScreenTest
- Resolved CHANGELOG.md lint failures (MD022)
- Completed LocalClipboard migration in ExportScreen.kt
- Clarified clipboard migration status in CHANGELOG.md
- [TemplateEditorScreen] fix nullable format argument in stringResource
- [ExportModels] remove redundant inner deprecation suppressions
- [ImportScreen] safe clipboard extraction and blank handling
- [AndroidManifest] add ACTION_VIEW query for APK installer compatibility

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@scripts/bump-version.ps1`:
- Around line 13-14: The PowerShell script scripts/bump-version.ps1 contains
non-ASCII glyphs but lacks a UTF-8 BOM; re-save or encode
scripts/bump-version.ps1 with UTF-8 + BOM (prefix EF BB BF) so PowerShell
correctly interprets box-drawing characters and symbols, or alternatively
replace the non-ASCII glyphs with ASCII equivalents throughout; after saving,
verify the file begins with EF BB BF in hex and re-run PSScriptAnalyzer to
confirm PSUseBOMForUnicodeEncodedFile passes.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 4b307138-4ac2-46a3-9639-5f9699855557

📥 Commits

Reviewing files that changed from the base of the PR and between ff44d89 and bf7bd4e.

📒 Files selected for processing (13)
  • CHANGELOG.md
  • app/src/androidTest/java/com/kingpaging/qwelcome/ui/templates/TemplateEditorScreenTest.kt
  • app/src/main/java/com/kingpaging/qwelcome/data/ExportModels.kt
  • app/src/main/java/com/kingpaging/qwelcome/data/GitHubAppUpdater.kt
  • app/src/main/java/com/kingpaging/qwelcome/ui/components/TemplateVariablesSheet.kt
  • app/src/main/java/com/kingpaging/qwelcome/ui/export/ExportScreen.kt
  • app/src/main/java/com/kingpaging/qwelcome/ui/import_pkg/ImportScreen.kt
  • app/src/main/java/com/kingpaging/qwelcome/ui/templates/TemplateEditorScreen.kt
  • app/src/main/java/com/kingpaging/qwelcome/ui/templates/TemplateListScreen.kt
  • app/src/main/res/values/strings.xml
  • gradle/libs.versions.toml
  • proto/build.gradle.kts
  • scripts/bump-version.ps1

Comment thread scripts/bump-version.ps1 Resolved
coderabbitai[bot]
coderabbitai Bot previously requested changes Apr 19, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@app/src/main/java/com/kingpaging/qwelcome/ui/import_pkg/ImportScreen.kt`:
- Around line 204-227: The clipboard handling currently calls
entry.clipData.getItemAt(0) without checking itemCount, which can throw
IndexOutOfBounds; update the block that starts with
clipboardManager.getClipEntry() to first check entry.clipData?.itemCount ?: 0 >
0 before calling getItemAt(0), and if itemCount is 0, run the existing
empty-clipboard path (soundPlayer.playBeep() + Toast for
R.string.toast_clipboard_empty) instead of attempting to access the item; keep
the existing flow for non-empty clips (extract text, use
exceedsImportLimit(...), call vm.onPasteContent(...) or show the "too large"
toast).
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 30cc8d66-0b5e-4ccb-a50e-3c2771a2cc98

📥 Commits

Reviewing files that changed from the base of the PR and between bf7bd4e and a6341fe.

📒 Files selected for processing (4)
  • app/src/main/AndroidManifest.xml
  • app/src/main/java/com/kingpaging/qwelcome/data/ExportModels.kt
  • app/src/main/java/com/kingpaging/qwelcome/ui/import_pkg/ImportScreen.kt
  • app/src/main/java/com/kingpaging/qwelcome/ui/templates/TemplateEditorScreen.kt

@H2OKing89
H2OKing89 merged commit 40cb443 into master Apr 19, 2026
3 checks passed
@H2OKing89
H2OKing89 deleted the release/v2.7.3 branch August 9, 2026 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant