Conversation
The main PRP for the Neighborhood currently has a second duplicate Python File Mod for xRandomBoolChange on nb01YeeshaPage07Vis/Enabled/Chance that runs the exact same logic twice when joinin the age, once on the YeeshaPage07 object and once on the YeeshaPage07Decal object. This means that randomization happens twice and it leads to odd side effects of the PFM not working as intended and probabilities not being correct because if any of these 2 seems to set visibility to 1, it will be visible, even if the second trigger sets it to 0 again. To fix this, I removed the duplicate on the Decal object.
Hoikas
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main PRP for the Neighborhood currently has a second duplicate Python File Mod for xRandomBoolChange on nb01YeeshaPage07Vis/Enabled/Chance that runs the exact same logic twice when joining the age, once on the YeeshaPage07 object and once on the YeeshaPage07Decal object. This means that randomization happens twice and it leads to odd side effects of the PFM not working as intended with probabilities not being correct because if any of these 2 seems to set visibility to 1, it will be visible, even if the second trigger sets it to 0 again. To fix this, I removed the duplicate on the Decal object.
As an aside, this is a bug that currently effectively makes it so that the Yeesha Page is always there when
nb01YeeshaPage07Enabled=1andnb01YeeshaPage07Chance=100even if that is NOT what the PFM intends. To allow persisting states properly I have opened H-uru/Plasma#1951 instead.