Skip to content

Upgrade to OpenGL4 - #6

Open
Lunanne wants to merge 13 commits into
H-uru:masterfrom
Lunanne:Opengl4
Open

Lunanne wants to merge 13 commits into
H-uru:masterfrom
Lunanne:Opengl4

Conversation

@Lunanne

@Lunanne Lunanne commented Oct 28, 2018

Copy link
Copy Markdown
Member

Includes the addition of GLM & GLEW. Didn't realize Deledrius was also working on that so it's probably best to wait with merging until after.

@Deledrius Deledrius left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After rebasing this to work from master, it compiles and runs, but the window only flashes briefly: the program exits through the "Failed to initialize GLEW" error path.

Comment thread src/CMakeLists.txt Outdated
Comment thread src/graphics/imPipeline.cpp
Comment thread src/graphics/imPipeline.h
Comment thread src/graphics/imPipeline.h Outdated
Comment thread CMakeLists.txt
Comment thread src/Main.cpp
@Deledrius Deledrius changed the title Upgrade to OpenGl4 Upgrade to OpenGL4 Oct 28, 2018
@Deledrius

Deledrius commented Oct 28, 2018

Copy link
Copy Markdown
Member

Upon further debugging, the GLEW error string returned is "Missing GL version". If I change the SDL_GL_CONTEXT_MAJOR_VERSION to 3 rather than 4, I finally receive a rendered screen containing the credits.

Looks like this is caused by a lack of support on my system for OGL 4.3, so I can't test the debug portion here.

@zrax zrax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After doing some research, I found that SDL2's bundled cmake modules are very different depending on whether it was built with cmake or autotools. I feel like including a full FindSDL2.cmake is overkill for fixing this, so I may try to create a simpler solution to handle both versions in a separate Pull Request.

Comment thread .gitignore Outdated
Comment thread .gitignore Outdated
Comment thread CMakeLists.txt Outdated
Comment thread libsquish/Makefile Outdated
Comment thread src/Main.cpp Outdated
Comment thread src/Main.cpp Outdated
Comment thread src/graphics/imPipeline.cpp Outdated
Comment thread src/graphics/imPipeline.cpp Outdated
Comment thread src/graphics/imPipeline.cpp Outdated
Comment thread src/graphics/imPipeline.cpp Outdated
@Lunanne

Lunanne commented Nov 14, 2018

Copy link
Copy Markdown
Member Author

@zrax is there a name for the specific indent style that you want? I'm having trouble configuring Clion to format it correctly and I would like to save us some time in the future

Comment thread src/Main.cpp Outdated
Comment thread src/Main.cpp Outdated
Comment thread src/Main.cpp
Comment thread src/graphics/imPipeline.cpp Outdated
Comment thread src/graphics/imPipeline.cpp Outdated
Comment thread src/graphics/imPipeline.h Outdated
Comment thread src/Main.cpp Outdated
Comment thread src/Main.cpp Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants