Skip to content

Add field loadBalancingScheme to resources compute_target_tcp_proxy (v1) - #18908

Open
rostislavbobo wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
rostislavbobo:targettcpproxy-lbscheme-global-ga
Open

Add field loadBalancingScheme to resources compute_target_tcp_proxy (v1)#18908
rostislavbobo wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
rostislavbobo:targettcpproxy-lbscheme-global-ga

Conversation

@rostislavbobo

Copy link
Copy Markdown
Member

Add the loadBalancingScheme field to Global Target TCP Proxy resource.

Fixes hashicorp/terraform-provider-google#29218

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: added field `loadBalancingScheme` to resource `google_compute_target_tcp_proxy`

@github-actions
github-actions Bot requested a review from ScottSuarez September 7, 2026 10:05
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician

modular-magician commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit e1ed748:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 6 files changed, 243 insertions(+), 53 deletions(-)
google-beta provider View Diff 5 files changed, 6 insertions(+), 125 deletions(-)
terraform-google-conversion View Diff 4 files changed, 33 insertions(+), 2 deletions(-)
Open in Cloud Shell View Diff 13 files changed, 390 insertions(+), 5 deletions(-)

Test report

Important

Manual Verification Required (GA-only additions)

The following tests are GA-only additions and cannot be run by VCR in Beta mode. Please verify them manually:

🔴 TestAccComputeTargetTcpProxy_targetTcpProxyBackendlessExample
🔴 TestAccComputeTargetTcpProxy_targetTcpProxyTlsRouteExample
🔴 TestAccNetworkServicesTlsRoute_networkServicesTlsRouteTargetTcpProxyBasicExample

Analytics

Total Tests Passed Skipped Affected
1669 1562 97 10
Affected Service Packages
  • compute
  • networkservices

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 10 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeBackendService_backendServiceInFlightExample
  • TestAccComputeInstanceFromMachineImage_diffProject
  • TestAccComputeInstanceTemplate_gracefulShutdown
  • TestAccComputeInstance_GracefulShutdownWithResetUpdate
  • TestAccComputeInstance_GracefulShutdownWithoutResetUpdate
  • TestAccComputeRegionInstanceTemplate_gracefulShutdown
  • TestAccComputeSecurityPolicy_withPreconfiguredWafConfig
  • TestAccComputeTargetInstance_withSecurityPolicy
  • TestAccComputeTargetTcpProxyListQuery_generated
  • TestAccComputeTargetTcpProxy_targetTcpProxyBasicExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccComputeTargetTcpProxyListQuery_generated
✅ Log TestAccComputeTargetTcpProxy_targetTcpProxyBasicExample
❌ Error · Log - TestAccComputeBackendService_backendServiceInFlightExample
❌ Error · Log - TestAccComputeInstanceFromMachineImage_diffProject
❌ Error · Log - TestAccComputeInstanceTemplate_gracefulShutdown
❌ Error · Log - TestAccComputeInstance_GracefulShutdownWithResetUpdate
❌ Error · Log - TestAccComputeInstance_GracefulShutdownWithoutResetUpdate
❌ Error · Log - TestAccComputeRegionInstanceTemplate_gracefulShutdown
❌ Error · Log - TestAccComputeSecurityPolicy_withPreconfiguredWafConfig
❌ Error · Log - TestAccComputeTargetInstance_withSecurityPolicy

Caution

Issues requiring attention before PR completion

🔴 Manual Verification Required: New tests were added that are skipped in presubmit tests. See the "Manual Verification Required" section at the top for details.

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@rostislavbobo, @ScottSuarez VCR tests complete for e1ed748!

@rostislavbobo

rostislavbobo commented Sep 7, 2026

Copy link
Copy Markdown
Member Author

The terraform-google-conversion-test-integration failure is caused by pre-existing failures in other compute resources.

Promotion of load_balancing_scheme on compute_target_tcp_proxy is passing its integration tests.

make testacc TEST=./google/services/compute TESTARGS='-run=TestAccComputeTargetTcpProxy' 
sh -c "'/usr/local/google/home/rostislavb/src/github.com/hashicorp/terraform-provider-google/scripts/gofmtcheck.sh'"
==> Checking that code complies with gofmt requirements...
go vet
TF_ACC_REFRESH_AFTER_APPLY=1 TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google/services/compute -v -run=TestAccComputeTargetTcpProxy -timeout 240m -ldflags="-X=github.com/hashicorp/terraform-provider-google/version.ProviderVersion=acc"
=== RUN   TestAccComputeTargetTcpProxyListQuery_generated
=== PAUSE TestAccComputeTargetTcpProxyListQuery_generated
=== RUN   TestAccComputeTargetTcpProxy_targetTcpProxyBasicExample
=== PAUSE TestAccComputeTargetTcpProxy_targetTcpProxyBasicExample
=== RUN   TestAccComputeTargetTcpProxy_targetTcpProxyBackendlessExample
=== PAUSE TestAccComputeTargetTcpProxy_targetTcpProxyBackendlessExample
=== RUN   TestAccComputeTargetTcpProxy_targetTcpProxyTlsRouteExample
=== PAUSE TestAccComputeTargetTcpProxy_targetTcpProxyTlsRouteExample
=== RUN   TestAccComputeTargetTcpProxy_update
=== PAUSE TestAccComputeTargetTcpProxy_update
=== CONT  TestAccComputeTargetTcpProxyListQuery_generated
=== CONT  TestAccComputeTargetTcpProxy_targetTcpProxyTlsRouteExample
=== CONT  TestAccComputeTargetTcpProxy_targetTcpProxyBackendlessExample
=== CONT  TestAccComputeTargetTcpProxy_update
=== CONT  TestAccComputeTargetTcpProxy_targetTcpProxyBasicExample
=== NAME  TestAccComputeTargetTcpProxyListQuery_generated
    list_compute_target_tcp_proxy_generated_test.go:58: Terraform CLI version 1.5.0 is below minimum version 1.14.0: skipping test
--- SKIP: TestAccComputeTargetTcpProxyListQuery_generated (0.15s)
--- PASS: TestAccComputeTargetTcpProxy_targetTcpProxyBackendlessExample (33.48s)
--- PASS: TestAccComputeTargetTcpProxy_targetTcpProxyTlsRouteExample (135.01s)
--- PASS: TestAccComputeTargetTcpProxy_update (341.49s)
--- PASS: TestAccComputeTargetTcpProxy_targetTcpProxyBasicExample (379.06s)
PASS
ok      github.com/hashicorp/terraform-provider-google/google/services/compute  379.235s
make testacc TEST=./google/services/networkservices TESTARGS='-run=TestAccNetworkServicesTlsRoute'
sh -c "'/usr/local/google/home/rostislavb/src/github.com/hashicorp/terraform-provider-google/scripts/gofmtcheck.sh'"
==> Checking that code complies with gofmt requirements...
go vet
TF_ACC_REFRESH_AFTER_APPLY=1 TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google/services/networkservices -v -run=TestAccNetworkServicesTlsRoute -timeout 240m -ldflags="-X=github.com/hashicorp/terraform-provider-google/version.ProviderVersion=acc"
=== RUN   TestAccNetworkServicesTlsRoute_networkServicesTlsRouteBasicExample
=== PAUSE TestAccNetworkServicesTlsRoute_networkServicesTlsRouteBasicExample
=== RUN   TestAccNetworkServicesTlsRoute_networkServicesTlsRouteRegionalBasicExample
=== PAUSE TestAccNetworkServicesTlsRoute_networkServicesTlsRouteRegionalBasicExample
=== RUN   TestAccNetworkServicesTlsRoute_networkServicesTlsRouteMeshBasicExample
=== PAUSE TestAccNetworkServicesTlsRoute_networkServicesTlsRouteMeshBasicExample
=== RUN   TestAccNetworkServicesTlsRoute_networkServicesTlsRouteGatewayBasicExample
=== PAUSE TestAccNetworkServicesTlsRoute_networkServicesTlsRouteGatewayBasicExample
=== RUN   TestAccNetworkServicesTlsRoute_networkServicesTlsRouteTargetTcpProxyBasicExample
=== PAUSE TestAccNetworkServicesTlsRoute_networkServicesTlsRouteTargetTcpProxyBasicExample
=== CONT  TestAccNetworkServicesTlsRoute_networkServicesTlsRouteBasicExample
=== CONT  TestAccNetworkServicesTlsRoute_networkServicesTlsRouteGatewayBasicExample
=== CONT  TestAccNetworkServicesTlsRoute_networkServicesTlsRouteTargetTcpProxyBasicExample
=== CONT  TestAccNetworkServicesTlsRoute_networkServicesTlsRouteMeshBasicExample
=== CONT  TestAccNetworkServicesTlsRoute_networkServicesTlsRouteRegionalBasicExample
--- PASS: TestAccNetworkServicesTlsRoute_networkServicesTlsRouteRegionalBasicExample (85.55s)
--- PASS: TestAccNetworkServicesTlsRoute_networkServicesTlsRouteGatewayBasicExample (104.07s)
--- PASS: TestAccNetworkServicesTlsRoute_networkServicesTlsRouteBasicExample (104.19s)
--- PASS: TestAccNetworkServicesTlsRoute_networkServicesTlsRouteMeshBasicExample (104.21s)
--- PASS: TestAccNetworkServicesTlsRoute_networkServicesTlsRouteTargetTcpProxyBasicExample (155.72s)
PASS
ok      github.com/hashicorp/terraform-provider-google/google/services/networkservices  155.889s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Terraform support for Load Balancing Scheme for global Target TCP Proxies (GA)

2 participants