Promoted compute:v1:NetworkEdgeSecurityService to GA - #18887
Conversation
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit fd627fa: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportImportant Manual Verification Required (GA-only additions) The following tests are GA-only additions and cannot be run by VCR in Beta mode. Please verify them manually: 🔴 TestAccComputeNetworkEdgeSecurityService_computeNetworkEdgeSecurityServiceBasicExample Analytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Manual Verification Required: New tests were added that are skipped in presubmit tests. See the "Manual Verification Required" section at the top for details. 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @melinath, @slevenick VCR tests complete for fd627fa! |
… resource_compute_network_edge_security_service_test.go
…-> resource_compute_network_edge_security_service_sweeper.go
|
@modular-magician reassign-reviewer |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit a8354f0: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportImportant Manual Verification Required (GA-only additions) The following tests are GA-only additions and cannot be run by VCR in Beta mode. Please verify them manually: 🔴 TestAccComputeNetworkEdgeSecurityService_computeNetworkEdgeSecurityServiceBasicExample Analytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Manual Verification Required: New tests were added that are skipped in presubmit tests. See the "Manual Verification Required" section at the top for details. 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @melinath, @slevenick VCR tests complete for a8354f0! |
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
VCR failures look unrelated |
|
@slevenick This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
6a5eae4
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.