Back-port the routine's "do not watch the PR" rule into the versioned prompt - #2934
Conversation
… prompt The live routine's stored prompt ends with "Do not watch the PR you fix", a line that has never existed in this file — it was added directly in the claude.ai web UI. Copying the versioned prompt over the routine, which the setup instructions tell you to do, would therefore have silently deleted it and let fired sessions start subscribing to the PRs they touch. Back-ported as a common rule, so it applies to the on-demand mode too, and documented the hazard: the routine's page is what actually runs, editing it leaves no trace in git, so the two must be diffed before pushing this file over it. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V1EYXKSQN8zZWrcTuCyduQ
Deploying gladys-plus with
|
| Latest commit: |
e1031c5
|
| Status: | 🚫 Build failed. |
github-actions
Bot
added
area:infra
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan includes up to 8 reviews per rolling hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe PR updates Claude autofix documentation. It adds prompt synchronization steps and prohibits monitoring a pull request after the routine posts its response. ChangesClaude autofix guidance
Estimated code review effort: 1 (Trivial) | ~3 minutes Merge Risk: ⚪ Minimal · up to This localized documentation and prompt update is merge-ready after normal checks, with no actionable merge-blocking risk remaining. Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🐳 A Docker image has been built for this branch and pushed to the GitHub Container Registry. You can test this pull request (AMD64 only) by pulling the image below: For example, run it with: sudo docker run -d \
--log-driver json-file \
--log-opt max-size=10m \
--cgroupns=host \
--restart=always \
--privileged \
--network=host \
--name gladys-claude-autofix-pr-conflicts-trigger-ny4c4q \
-e NODE_ENV=production \
-e SERVER_PORT=80 \
-e TZ=Europe/Paris \
-e SQLITE_FILE_PATH=/var/lib/gladysassistant/gladys-production.db \
-v /var/run/docker.sock:/var/run/docker.sock \
-v /var/lib/gladysassistant:/var/lib/gladysassistant \
-v /dev:/dev \
-v /run/udev:/run/udev:ro \
ghcr.io/gladysassistant/gladys-preview:claude-autofix-pr-conflicts-trigger-ny4c4qThis comment and the image are automatically updated on every new commit pushed to this pull request. Need an ARM64 image (Raspberry Pi, Apple Silicon, …)? Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2934 +/- ##
=======================================
Coverage 99.52% 99.52%
=======================================
Files 1242 1242
Lines 89235 89235
=======================================
Hits 88809 88809
Misses 426 426 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Docs and versioned-prompt only. The new common rule matches what the live routine already does, and putting it in git (with the copy-hazard note) is what makes the pending prompt copy from #2932 safe.
What this does
- Adds
Do not watch the PR you fixas a common rule in.github/CLAUDE_AUTOFIX_ROUTINE_PROMPT.md, so both scheduled and on-demand sessions post their answer and stop instead of subscribing to PR activity. - Documents that the routine page is what actually runs, and that copying this file over a drifted web-UI prompt silently deletes those edits.
Why this is the right place
Watching a PR after the pass would recreate the event-driven loop these workflows exist to kill (push → bot re-review → react again). Binding it as a common rule also covers /claude: that mode should answer once, not start monitoring. The expansion beyond the live one-liner (do not subscribe / end the run / follow-ups via the next cron or a new /claude) is unambiguous and does not conflict with “fetch the PR and do the pass.”
Not in this diff (and fine)
- No workflow YAML, no Gladys runtime, no
server/constants.jscategories/types. - Merging git still does not change live sessions until the prompt is copied to the routine page. That remaining ops step is already documented; this PR is what makes that copy not drop the watch rule.
Cloudflare Pages is unrelated (gladys-plus). Front test/build, server lint/test, and the rest of the PR jobs that have finished are green.
Ready to merge from this side.
Sent by Cursor Automation: Automatic PR review
2 participants
Description
Follow-up to #2932, found while diagnosing why a
/claudecommand on #2910 did nothing.The live routine's stored prompt ends with a line that has never existed in
.github/CLAUDE_AUTOFIX_ROUTINE_PROMPT.md, on any revision:It was added directly in the claude.ai web UI, which leaves no trace in git. The setup instructions in
CLAUDE_AUTOFIX.mdtell you to copy the versioned file onto the routine's page — doing that today would have silently deleted that instruction, and fired sessions would have started subscribing to the activity of every PR they touch.This PR back-ports it as a common rule, so it now also binds the on-demand mode (a
/claudesession should answer and stop, not start watching either), and documents the hazard that caused it: the routine's page is what actually runs, so the two must be diffed before pushing this file over it.No workflow behaviour changes — this touches only the versioned prompt and its documentation.
Why this matters now
#2932 is merged, so
claude-on-demand-autofix.ymlis live and firing correctly. But the routine's stored prompt is still the scheduled-only version, so an on-demand payload fails its validation and the session stops without doing anything. That is the documented pending step, not a defect — the prompt still has to be copied to the routine's page for/claudeto work. This PR makes that copy safe to perform.Forum
Checklist
.github/*.mdis outside prettier's configured scope.Generated by Claude Code
Summary by CodeRabbit