Repository navigation
Fix GitHub Pages documentation deployment - #19
Merged
Merged
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
There was a problem hiding this comment.
Pull request overview
This PR fixes GitHub Pages documentation deployment by adding an explicit MkDocs configuration, tightening the docs build to fail on regressions, and updating status/dashboard links to point at the live Pages site URL.
Changes:
- Add a tracked
mkdocs.ymlwith the intendedsite_url,docs_dir, theme, and navigation. - Update the docs workflow to stage markdown into the MkDocs
docs/tree, normalize select links, and build in--strictmode. - Update workflow status/dashboard “Documentation” links to the GitHub Pages endpoint.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
WORKFLOW_STATUS.md |
Points the “Documentation” quick link at the GitHub Pages site instead of the repo README. |
mkdocs.yml |
Introduces the in-repo MkDocs configuration (site metadata, theme, and nav). |
.github/workflows/status.yml |
Generates the documentation link dynamically using the repository’s Pages URL. |
.github/workflows/documentation.yml |
Stages docs inputs and builds MkDocs with --strict before deploying to Pages. |
Suppressed comments (2)
mkdocs.yml:40
- The nav includes
CONTRIBUTING.md,SECURITY.md, andWORKFLOW_STATUS.mdunderdocs_dir: docs, but those files are not present underdocs/in the repository and are only copied there during the workflow. This will break local builds and any docs checks that run without that copy step. Either commitdocs/CONTRIBUTING.md,docs/SECURITY.md,docs/WORKFLOW_STATUS.md(or generated equivalents) or document/provide a local build script that performs the same staging step.
- Contributing: CONTRIBUTING.md
- Security: SECURITY.md
- Workflow Status: WORKFLOW_STATUS.md
mkdocs.yml:43
- The docs include Mermaid diagrams (e.g.,
docs/ARCHITECTURE.mduses fenced blocks with languagemermaid), but the MkDocs config doesn't enable Mermaid rendering. Add the Mermaid plugin (or Material's mermaid configuration) so diagrams render instead of showing as plain code blocks.
plugins:
- search
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| site_url: https://gizzzmo.github.io/Ai_shell/ | ||
| repo_url: https://github.com/GizzZmo/Ai_shell | ||
| repo_name: GizzZmo/Ai_shell | ||
| docs_dir: docs |
Comment on lines
147
to
150
| - name: Install dependencies | ||
| run: | | ||
| pip install mkdocs mkdocs-material mkdocs-mermaid2-plugin | ||
| pip install mkdocs mkdocs-material | ||
| pip install -r requirements.txt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
GitHub Pages deployment was publishing a site with the wrong canonical URL and a docs build that tolerated broken navigation and unresolved links. This change makes the Pages config explicit in-repo and aligns the generated site with the repository’s actual Pages endpoint and content layout.
Type of Change
Please delete options that are not relevant.
Related Issues
Changes Made
mkdocs.ymlwith the correctsite_url, docs root, and navTesting
python -m pytest tests/)black ai_shell/ tests/)flake8 ai_shell/ tests/)Security Considerations
Documentation
Screenshots (if applicable)
Add screenshots to help explain your changes.
Checklist
Additional Notes
The docs workflow now treats broken nav/link wiring as a build failure instead of publishing a degraded site.