Skip to content

Fix GitHub Pages documentation deployment - #19

Merged
GizzZmo merged 1 commit into
mainfrom
copilot/update-deployment-and-fix-github-pages
Aug 3, 2026
Merged

GizzZmo merged 1 commit into
mainfrom
copilot/update-deployment-and-fix-github-pages

Conversation

Copilot AI commented Aug 3, 2026

Copy link
Copy Markdown

Description

GitHub Pages deployment was publishing a site with the wrong canonical URL and a docs build that tolerated broken navigation and unresolved links. This change makes the Pages config explicit in-repo and aligns the generated site with the repository’s actual Pages endpoint and content layout.

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Performance improvement
  • Code refactoring
  • CI/CD changes

Related Issues

Changes Made

  • Make Pages config explicit — add a tracked mkdocs.yml with the correct site_url, docs root, and nav
  • Fix docs publish inputs — update the workflow to stage repository markdown into the docs site and normalize links before build
  • Fail on docs regressions — switch the docs build to strict mode and update status/dashboard links to the live Pages URL
site_url: https://gizzzmo.github.io/Ai_shell/
docs_dir: docs

nav:
  - Home: index.md
  - Usage: USAGE.md
  - Contributing: CONTRIBUTING.md
  - Security: SECURITY.md

Testing

  • Tests pass locally (python -m pytest tests/)
  • Code is properly formatted (black ai_shell/ tests/)
  • Linting passes (flake8 ai_shell/ tests/)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Security Considerations

  • This change does not introduce security vulnerabilities
  • Command execution is properly validated
  • No sensitive information is exposed in logs
  • API keys and credentials are handled securely

Documentation

  • I have updated the documentation accordingly
  • I have added docstrings to new functions/classes
  • Examples are updated if needed
  • README.md is updated if needed

Screenshots (if applicable)

Add screenshots to help explain your changes.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional Notes

The docs workflow now treats broken nav/link wiring as a build failure instead of publishing a degraded site.

@GizzZmo
GizzZmo marked this pull request as ready for review August 3, 2026 18:08
Copilot AI review requested due to automatic review settings August 3, 2026 18:08
@gemini-code-assist

Copy link
Copy Markdown

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@GizzZmo
GizzZmo merged commit 4afa1dd into main Aug 3, 2026
18 checks passed
@GizzZmo
GizzZmo deleted the copilot/update-deployment-and-fix-github-pages branch August 3, 2026 18:09
@github-actions github-actions Bot added bug Something isn't working ci-cd documentation Improvements or additions to documentation size/L work-in-progress labels Aug 3, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes GitHub Pages documentation deployment by adding an explicit MkDocs configuration, tightening the docs build to fail on regressions, and updating status/dashboard links to point at the live Pages site URL.

Changes:

  • Add a tracked mkdocs.yml with the intended site_url, docs_dir, theme, and navigation.
  • Update the docs workflow to stage markdown into the MkDocs docs/ tree, normalize select links, and build in --strict mode.
  • Update workflow status/dashboard “Documentation” links to the GitHub Pages endpoint.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
WORKFLOW_STATUS.md Points the “Documentation” quick link at the GitHub Pages site instead of the repo README.
mkdocs.yml Introduces the in-repo MkDocs configuration (site metadata, theme, and nav).
.github/workflows/status.yml Generates the documentation link dynamically using the repository’s Pages URL.
.github/workflows/documentation.yml Stages docs inputs and builds MkDocs with --strict before deploying to Pages.
Suppressed comments (2)

mkdocs.yml:40

  • The nav includes CONTRIBUTING.md, SECURITY.md, and WORKFLOW_STATUS.md under docs_dir: docs, but those files are not present under docs/ in the repository and are only copied there during the workflow. This will break local builds and any docs checks that run without that copy step. Either commit docs/CONTRIBUTING.md, docs/SECURITY.md, docs/WORKFLOW_STATUS.md (or generated equivalents) or document/provide a local build script that performs the same staging step.
  - Contributing: CONTRIBUTING.md
  - Security: SECURITY.md
  - Workflow Status: WORKFLOW_STATUS.md

mkdocs.yml:43

  • The docs include Mermaid diagrams (e.g., docs/ARCHITECTURE.md uses fenced blocks with language mermaid), but the MkDocs config doesn't enable Mermaid rendering. Add the Mermaid plugin (or Material's mermaid configuration) so diagrams render instead of showing as plain code blocks.
plugins:
  - search

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread mkdocs.yml
site_url: https://gizzzmo.github.io/Ai_shell/
repo_url: https://github.com/GizzZmo/Ai_shell
repo_name: GizzZmo/Ai_shell
docs_dir: docs
Comment on lines 147 to 150
- name: Install dependencies
run: |
pip install mkdocs mkdocs-material mkdocs-mermaid2-plugin
pip install mkdocs mkdocs-material
pip install -r requirements.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ci-cd documentation Improvements or additions to documentation size/L work-in-progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants