Migrate getUnreadCounts response to the generated WrappedUnreadCountsResponse model - #6619
Migrate getUnreadCounts response to the generated WrappedUnreadCountsResponse model#6619gpunto wants to merge 1 commit into
Conversation
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
SDK Size Comparison 📏
|
fb9abc3 to
6adf960
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (14)
💤 Files with no reviewable changes (3)
WalkthroughThe unread-count API now returns ChangesUnread counts migration
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|



Goal
Migrate the
getUnreadCountsresponse (GET /unread) from the hand-writtenUnreadDtofamily to the generatedWrappedUnreadCountsResponsenetwork model.Part of AND-1291
Implementation
WrappedUnreadCountsResponse,UnreadCountsChannel,UnreadCountsChannelType,UnreadCountsThread; remove the hand-writtenUnreadDtos(UnreadDto/UnreadChannelDto/UnreadThreadDto/UnreadChannelByTypeDto).GeneralApi.getUnreadCounts()and map the generated model to the domainUnreadCountsinDomainMapping.Testing
UnreadCountsParsingTestlocks the wire shape (JSON ->WrappedUnreadCountsResponse->UnreadCounts), including the requiredduration, the per-team map, and date round-trips.DomainMappingTestrewritten with explicit expected values (no recompute-the-mapper tautology).getUnreadCounts()on the wire: parses cleanly with populated counts, channels, and channelsByType.spotlessCheck,apiCheck(no public-API change),detekt, and the full clienttestDebugUnitTestsuite pass.Summary by CodeRabbit
Bug Fixes
Tests