Repository navigation
Support all chat integration origins in generated API types - #63
Open
thedogwiththedataonit wants to merge 2 commits into
Open
thedogwiththedataonit wants to merge 2 commits into
thedogwiththedataonit wants to merge 2 commits into
Conversation
thedogwiththedataonit
marked this pull request as ready for review
October 13, 2026 08:18
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The public chat-origin types currently describe Slack only. Regenerate the OpenAPI mirror and TypeScript declarations so chat responses can report any supported chat integration, including Teams, Telegram and WhatsApp.
Pin the complete 39-origin nullable union in the chat-list type assertion so removal of an origin or widening to string fails typecheck. The negative control failed as expected, and the complete contract passes. Synchronize the current canonical consent and Figma import contracts. No package version or release changes.
Validation: full TypeScript check; chat-list and Figma tests (9 passed); focused ESLint and formatting checks. Final review fix: TypeScript, ESLint, Prettier and all 7 chat-list tests pass. The automated review thread is resolved.
The PR appears safe to merge; the previous test gap is fixed and no new blocking issue was found.Summary
Expands chat-origin types in the OpenAPI mirror and generated TypeScript declarations.
No new actionable issues were found in the changes since the previous review.
Reviews (2) · Last reviewed commit: "test: pin complete chat origin contract" · Reviewed by Greptile