Skip to content

Guard getResourceStatuses against a null resource #2566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Valyrian-Code wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Guard getResourceStatuses against a null resource #2566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion geonode_mapstore_client/client/js/utils/ResourceUtils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ export const getResourceStatuses = (resource, userInfo) => {
isDeleting,
isCopying,
items: [
...(resource.advertised === false ? [{
...(resource?.advertised === false ? [{
type: 'icon',
tooltipId: 'resourcesCatalog.unadvertised',
glyph: 'eye-slash'
Expand Down
10 changes: 9 additions & 1 deletion geonode_mapstore_client/client/js/utils/__tests__/ResourceUtils-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,18 @@ import {
canManageResourceSettings,
canAccessPermissions,
formatResourceLinkUrl,
canEditMap
canEditMap,
getResourceStatuses
} from '../ResourceUtils';

describe('Test Resource Utils', () => {
it('getResourceStatuses does not throw for a null resource', () => {
const status = getResourceStatuses(null);
expect(status.isProcessing).toBe(false);
expect(status.isDeleting).toBe(false);
expect(status.isCopying).toBe(false);
expect(status.items).toEqual([]);
});
it('should getViewedResourcePermissions', () => {
const data = [{
name: "testType",
Expand Down