Skip to content

Fix gnDownload reducer mutating previous state on DOWNLOAD_METADATA_COMPLETE #2565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Valyrian-Code wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix gnDownload reducer mutating previous state on DOWNLOAD_METADATA_COMPLETE #2565

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8b5d7b
Fix gnDownload reducer mutating previous state on DOWNLOAD_METADATA_C…
Valyrian-Code Jun 11, 2026
1874e18
Use destructuring rest to omit the completed pk immutably
Valyrian-Code Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions geonode_mapstore_client/client/js/reducers/__tests__/gndownload-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,11 @@ describe('gndownload reducer', () => {
}
});
});
it('downloadMetaDataComplete does not mutate the previous state', () => {
const previousLinkState = { 1: true };
const state = { downloads: { ISO: previousLinkState, DublinCore: {} } };
gndownload(state, downloadMetaDataComplete('ISO', 1));
// a reducer must be pure: the previous state object must remain untouched
expect(previousLinkState).toEqual({ 1: true });
});
});
14 changes: 6 additions & 8 deletions geonode_mapstore_client/client/js/reducers/gndownload.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,17 +31,15 @@ function gnDownload(state = defaultState, action) {
};
}
case DOWNLOAD_METADATA_COMPLETE: {
const newState = { ...state };
const linkType = action?.link?.split(' ').join('');
const downloads = newState.downloads[linkType];
delete downloads[action.pk];
// copy the link bucket before deleting so the previous state is not mutated
const remaining = { ...(state.downloads[linkType] || {}) };
delete remaining[action.pk];
Comment thread
Valyrian-Code marked this conversation as resolved.
Outdated
return {
...newState,
...state,
downloads: {
...newState.downloads,
[linkType]: {
...downloads
}
...state.downloads,
[linkType]: remaining
}
};
}
Expand Down