Skip to content

[ENHANCEMENT] greyed out mods that arent compatible - #7940

Open
kiryvajiravuth wants to merge 1 commit into
FunkinCrew:preview/public-playtestfrom
kiryvajiravuth:greyed-mod
Open

[ENHANCEMENT] greyed out mods that arent compatible #7940
kiryvajiravuth wants to merge 1 commit into
FunkinCrew:preview/public-playtestfrom
kiryvajiravuth:greyed-mod

Conversation

@kiryvajiravuth

Copy link
Copy Markdown
Contributor

Linked Issues

closes #7939

Description

Currently, mods whose api_version doesn't satisfy the game's API version rule (>=0.8.0 <0.10.0) are silently hidden from the Mod Menu. If a mod is incompatible, players have no way to see it, why its missing, or even know that it exists at all.

This PR makes incompatible mods visible but greyed out in the Mod Menu:

  • PolymodHandler added getAllModsIncludingIncompatible(), scanMods(includeIncompatible, force) (omits the API version rule so broken mods still surface), isModCompatible(), and getDisabledModsIncludingIncompatible() (incompatible mods sorted to the bottom of the Disabled list).
  • ModMenuItem new compatible flag and setIncompatible() which greys out the title/description and dims the icon.
  • ModMenuState disabled list now scans permissively and marks incompatible items; enabled list filters to compatible-only; attempting to enable an incompatible mod is blocked with the existing deny SFX + background flash feedback.

An incompatible mod still cannot be enabled , it just isn't invisible anymore.

Screenshots/Videos

enhancement-footage.mp4

@github-actions github-actions Bot added status: pending triage Awaiting review. pr: haxe PR modifies game code. size: large A large pull request with more than 100 changes. and removed status: pending triage Awaiting review. labels Aug 14, 2026
@NotHyper-474 NotHyper-474 added status: pending triage Awaiting review. type: enhancement Involves an enhancement or new feature. topic: mod menu Related to the operation of the Mod Menu and Quick Menu. labels Aug 14, 2026

@Kade-github Kade-github left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without looking at the code, I would say I want one thing here.

A little text that is displayed overtop the description, bottom anchored that is in red saying it is incompatible with the current game version.

This does look like something we'd want though! Thank you for your pr.

@NotHyper-474 NotHyper-474 added status: needs revision Cannot be approved because it is awaiting some work by the contributor. and removed status: pending triage Awaiting review. labels Aug 15, 2026
@kiryvajiravuth

Copy link
Copy Markdown
Contributor Author

i accidently pushed without any testing mb
i was in a rush

@kiryvajiravuth

Copy link
Copy Markdown
Contributor Author

this seems good enough for me , probably work on the mobile version next

Screenshot (598)

@kiryvajiravuth

Copy link
Copy Markdown
Contributor Author

yup i think its done
both windows and android works perfectly
any thoughts or changes?

mod-menu-test-small.mp4

@Kade-github Kade-github left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah code looks solid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: haxe PR modifies game code. size: large A large pull request with more than 100 changes. status: needs revision Cannot be approved because it is awaiting some work by the contributor. topic: mod menu Related to the operation of the Mod Menu and Quick Menu. type: enhancement Involves an enhancement or new feature.

Development

Successfully merging this pull request may close these issues.

3 participants