Skip to content

[CRASHFIX] Fix crash scanning partially written zips in the mod menu - #7918

Open
kiryvajiravuth wants to merge 1 commit into
FunkinCrew:preview/public-playtestfrom
kiryvajiravuth:mod-menu-fix
Open

[CRASHFIX] Fix crash scanning partially written zips in the mod menu#7918
kiryvajiravuth wants to merge 1 commit into
FunkinCrew:preview/public-playtestfrom
kiryvajiravuth:mod-menu-fix

Conversation

@kiryvajiravuth

Copy link
Copy Markdown
Contributor

Linked Issues

closes #7917

Description

while a zip is mid write that rescan tick is skipped; the mod appears once the zip finishes. No crash and the game still boots with a bad zip present.

Screenshots/Videos

before :

before.mp4

after :

after.mp4

@github-actions github-actions Bot added size: medium A medium pull request with 100 or fewer changes. pr: haxe PR modifies game code. status: pending triage Awaiting review. and removed size: medium A medium pull request with 100 or fewer changes. labels Aug 11, 2026
@NotHyper-474 NotHyper-474 added type: major bug Involves a major bug, including crashes, softlocks, or issues blocking progression topic: mod menu Related to the operation of the Mod Menu and Quick Menu. size: medium A medium pull request with 100 or fewer changes. labels Aug 11, 2026
@Hundrec

Hundrec commented Aug 11, 2026

Copy link
Copy Markdown
Member

That was fast, I didn't think this could be fixed

@NotHyper-474

Copy link
Copy Markdown
Collaborator

That was fast, I didn't think this could be fixed

Nothing an old and reliable try-catch can't resolve :trollface:

@Hundrec
Hundrec self-requested a review August 11, 2026 16:25
@kiryvajiravuth
kiryvajiravuth force-pushed the mod-menu-fix branch 2 times, most recently from b795531 to fae6d0a Compare August 14, 2026 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: haxe PR modifies game code. size: medium A medium pull request with 100 or fewer changes. status: pending triage Awaiting review. topic: mod menu Related to the operation of the Mod Menu and Quick Menu. type: major bug Involves a major bug, including crashes, softlocks, or issues blocking progression

Development

Successfully merging this pull request may close these issues.

Crash Report: Partially written or corrupted .zip mods crash the game when scanned

3 participants