Skip to content

[BUGFIX] Fix hotreloading in a custom state not carrying over the changes - #7916

Merged
AbnormalPoof merged 1 commit into
FunkinCrew:preview/public-playtestfrom
KoloInDaCrib:i-thought-i-was-going-crazy-lol
Aug 18, 2026
Merged

[BUGFIX] Fix hotreloading in a custom state not carrying over the changes#7916
AbnormalPoof merged 1 commit into
FunkinCrew:preview/public-playtestfrom
KoloInDaCrib:i-thought-i-was-going-crazy-lol

Conversation

@KoloInDaCrib

@KoloInDaCrib KoloInDaCrib commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Linked Issues

My tweaking ass

Description

When hot-reloading in a custom menu, the changes wouldn't be carried over and would only be visible in the subsequent hotreload. This is because the scripted menu was being initialized before the actual hotreloading would happen.

Co-authored by @MightyTheArmiddilo cuz he originally came up with the idea for the fix. I just had to modify it because null-safety and type checking were being a pain in the ass.

Screenshots/Videos

Before

the.only.state.shown.in.funkkast.before.mp4

After

the.only.state.shown.in.funkkast.after.mp4

Co-Authored-By: MightyTheArmiddilo <132609476+MightyTheArmiddilo@users.noreply.github.com>
@github-actions github-actions Bot added status: pending triage Awaiting review. size: small A small pull request with 10 or fewer changes. pr: haxe PR modifies game code. labels Aug 11, 2026
@NotHyper-474 NotHyper-474 added type: minor bug Involves a minor bug or issue. topic: mods Related to the creation or use of mods. labels Aug 11, 2026

@EliteMasterEric EliteMasterEric left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

@Hundrec Hundrec added status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: pending triage Awaiting review. labels Aug 11, 2026
@Hundrec Hundrec added this to the Mod Menu milestone Aug 11, 2026
@AbnormalPoof
AbnormalPoof merged commit 7ced648 into FunkinCrew:preview/public-playtest Aug 18, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: haxe PR modifies game code. size: small A small pull request with 10 or fewer changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. topic: mods Related to the creation or use of mods. type: minor bug Involves a minor bug or issue.

Development

Successfully merging this pull request may close these issues.

5 participants