[BUGFIX] Fix BF and GF blinking in Mod Menu - #7893
Open
immalloy wants to merge 2 commits into
Open
Conversation
mod menu used to reset blinkTimer after 100 seconds, but left BF and GF deadlines unchanged which once reset the deadlines could no longer be reached and caused issue FunkinCrew#7821
github-actions
Bot
added
size: small
NotHyper-474
added
type: minor bug
4 tasks
Hundrec
added
status: reviewing internally
Author
|
stupid amount of dedication on the video 😭 |
NotHyper-474
reviewed
Aug 8, 2026
NotHyper-474
left a comment
NotHyper-474
left a comment
Collaborator
There was a problem hiding this comment.
I think the more logical way to fix it is to reset bfBlink and gfBlink along blinkTimer.
The current fix will make the interval between blinks increase without limit, and I think the intention of the removed code was precisely to limit this increase.
Member
|
I agree with the above and would like for this PR to be adjusted accordingly |
Hundrec
added
status: needs revision
github-actions
Bot
added
size: tiny
NotHyper-474
added
status: pending triage
Author
|
check! i reimplemented the originaal fix i did which is what hundrenc and hyper requested! |
Hundrec
self-requested a review
August 11, 2026 14:22
EliteMasterEric
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issues
Closes #7821
Description
After the Mod Menu had been open for around 100 seconds, BF and GF would stop blinking. This happened because
blinkTimerwas reset to0, whilebfBlinkandgfBlinkkept their absolute value deadlines. Once those deadlines were past 100 seconds, the timer could no longer reach them.This removes the timer reset so the timer and both blink deadlines stay on the same timeline. nothing else is affected.
I confirmed the old timer behavior and the new time behavior with the video below.
Screenshots/Videos
8mb.video-WTe-53UjORnx.mp4