Skip to content

[ENHANCEMENT] Instrumental field automatically added in the metadata if the song is a variation - #7879

Open
LeaNimatics wants to merge 1 commit into
FunkinCrew:preview/public-playtestfrom
LeaNimatics:metadata-instrumental-variation-saving
Open

[ENHANCEMENT] Instrumental field automatically added in the metadata if the song is a variation#7879
LeaNimatics wants to merge 1 commit into
FunkinCrew:preview/public-playtestfrom
LeaNimatics:metadata-instrumental-variation-saving

Conversation

@LeaNimatics

@LeaNimatics LeaNimatics commented Aug 6, 2026 •
edited
Loading

Copy link
Copy Markdown

Description

This PR makes that, when saving a song, if it's a variation, it will automatically add the "instrumental" field into the json with the variation name, and if's not a variation of a already existing song, it will not write it to the JSON metadata.

Screenshots/Videos

Here is a video of the feature in action !

2026-08-06.21-32-57.mp4

@LeaNimatics LeaNimatics changed the title Instrumental variation saving [ENHANCEMENT] Instrumental field automatically added in the metadata if the song is a variation Aug 6, 2026
@LeaNimatics

LeaNimatics commented Aug 6, 2026

Copy link
Copy Markdown
Author

Wow sorry I got the wrong branch at first I was super scared sorry again for the conflict 🥹
I'm super stressed 😭

@NotHyper-474 NotHyper-474 added size: small A small pull request with 10 or fewer changes. status: pending triage Awaiting review. type: enhancement Involves an enhancement or new feature. topic: chart editor Related to the operation of the Chart Editor. labels Aug 6, 2026
@LeaNimatics
LeaNimatics changed the base branch from develop to preview/public-playtest August 9, 2026 03:47
@LeaNimatics
LeaNimatics changed the base branch from preview/public-playtest to develop August 9, 2026 03:47
@LeaNimatics
LeaNimatics force-pushed the metadata-instrumental-variation-saving branch from 008ee46 to 292d317 Compare August 9, 2026 03:55
@github-actions github-actions Bot added the pr: haxe PR modifies game code. label Aug 9, 2026
@LeaNimatics
LeaNimatics changed the base branch from develop to preview/public-playtest August 9, 2026 03:55
@LeaNimatics
LeaNimatics changed the base branch from preview/public-playtest to develop August 9, 2026 03:55
@LeaNimatics
LeaNimatics force-pushed the metadata-instrumental-variation-saving branch from 292d317 to 7fc5fe8 Compare August 9, 2026 03:59
@github-actions github-actions Bot added size: huge A huge pull request with more than 500 changes. size: small A small pull request with 10 or fewer changes. pr: documentation PR modifies documentation or README files. pr: github PR modifies GitHub metadata files. and removed size: small A small pull request with 10 or fewer changes. labels Aug 9, 2026
@LeaNimatics
LeaNimatics force-pushed the metadata-instrumental-variation-saving branch from 7fc5fe8 to 008ee46 Compare August 9, 2026 04:00
@github-actions github-actions Bot added size: huge A huge pull request with more than 500 changes. and removed size: huge A huge pull request with more than 500 changes. pr: documentation PR modifies documentation or README files. pr: github PR modifies GitHub metadata files. labels Aug 9, 2026
@LeaNimatics
LeaNimatics changed the base branch from develop to preview/public-playtest August 9, 2026 04:01
@LeaNimatics
LeaNimatics changed the base branch from preview/public-playtest to develop August 9, 2026 04:01
@LeaNimatics
LeaNimatics force-pushed the metadata-instrumental-variation-saving branch from 008ee46 to 560a006 Compare August 9, 2026 04:08
@LeaNimatics
LeaNimatics changed the base branch from develop to preview/public-playtest August 9, 2026 04:08
@github-actions github-actions Bot removed size: small A small pull request with 10 or fewer changes. pr: haxe PR modifies game code. labels Aug 9, 2026
@github-actions github-actions Bot added size: small A small pull request with 10 or fewer changes. pr: documentation PR modifies documentation or README files. pr: github PR modifies GitHub metadata files. labels Aug 9, 2026
@NotHyper-474 NotHyper-474 added pr: haxe PR modifies game code. and removed pr: documentation PR modifies documentation or README files. pr: github PR modifies GitHub metadata files. size: huge A huge pull request with more than 500 changes. labels Aug 9, 2026
@Hundrec Hundrec added status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: pending triage Awaiting review. labels Aug 11, 2026
@Hundrec Hundrec added this to the 0.9.0 - Week 8 milestone Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EliteMasterEric EliteMasterEric EliteMasterEric approved these changes

Assignees

No one assigned

Labels

pr: haxe PR modifies game code. size: small A small pull request with 10 or fewer changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. topic: chart editor Related to the operation of the Chart Editor. type: enhancement Involves an enhancement or new feature.

Milestone

0.9.0 - Week 8

Development

Successfully merging this pull request may close these issues.

4 participants

@LeaNimatics @EliteMasterEric @NotHyper-474 @Hundrec