Skip to content

Fix SABR redirect handling not updating SABR URL which is actually used - #9689

Merged
FreeTubeBot merged 1 commit into
FreeTubeApp:developmentfrom
PikachuEXE:fix/sabr-redirect
Aug 25, 2026
Merged

Fix SABR redirect handling not updating SABR URL which is actually used#9689
FreeTubeBot merged 1 commit into
FreeTubeApp:developmentfrom
PikachuEXE:fix/sabr-redirect

Conversation

@PikachuEXE

@PikachuEXE PikachuEXE commented Aug 25, 2026

Copy link
Copy Markdown
Member

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

Closes #9677

Description

SABR set received URL but not to a property used in code

Screenshots

N/A

Testing

No idea since redirect happens rarely but you can try those provided in comments in #9677

Desktop

  • OS:
  • OS Version:
  • FreeTube version:

Additional context

@FreeTubeBot
FreeTubeBot enabled auto-merge (squash) August 25, 2026 02:36
@github-actions github-actions Bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Aug 25, 2026
@PikachuEXE PikachuEXE mentioned this pull request Aug 25, 2026
Closed
absidue
absidue approved these changes Aug 25, 2026
View reviewed changes

@absidue absidue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that the changes work by watching a video with my VPN set to France, then switching to New Zealand and checking in the devtools network tab that /videoplayback requests started going to a different hostname.

Merged
1 task
@FreeTubeBot
FreeTubeBot merged commit 3e8a769 into FreeTubeApp:development Aug 25, 2026
6 checks passed
@github-actions github-actions Bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Aug 25, 2026
PikachuEXE added a commit that referenced this pull request Aug 26, 2026
@PikachuEXE
Merge branch 'development' into dependabot/npm_and_yarn/shaka-player-…
c94a765 
…5.2.2

* development:
  Translated using Weblate (French)
  Translated using Weblate (Czech)
  Translated using Weblate (Estonian)
  Translated using Weblate (Polish)
  Translated using Weblate (Estonian)
  Translated using Weblate (Italian)
  ! Fix SABR redirect handling not updating SABR URL which is actually used (#9689)
  Translated using Weblate (Hungarian)
  Translated using Weblate (Turkish)
  Change: Add information about current/default invidious instance (#9464)
  Implement threaded replies with YouTube.js 18.0.0 (#9555)
  fix: getRegions script failing (#9684)
  Move important block and correct project info (#9676)

# Conflicts:
#	pnpm-lock.yaml
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Aug 26, 2026
@PikachuEXE
Merge branch 'test/large-video-buffer' into custom-builds/current
3dab8e7 
* test/large-video-buffer: (49 commits)
  x4
  triple
  * Update shaka confg to double streaming.bufferingGoal & streaming.bufferBehind
  Translated using Weblate (French)
  Translated using Weblate (Czech)
  Translated using Weblate (Estonian)
  Translated using Weblate (Polish)
  Translated using Weblate (Estonian)
  Translated using Weblate (Italian)
  ! Fix SABR redirect handling not updating SABR URL which is actually used (FreeTubeApp#9689)
  Translated using Weblate (Hungarian)
  Translated using Weblate (Turkish)
  Change: Add information about current/default invidious instance (FreeTubeApp#9464)
  Implement threaded replies with YouTube.js 18.0.0 (FreeTubeApp#9555)
  fix: getRegions script failing (FreeTubeApp#9684)
  Move important block and correct project info (FreeTubeApp#9676)
  Remove offensive wording in code (FreeTubeApp#9470)
  Bump electron from 43.3.0 to 43.4.0 (FreeTubeApp#9673)
  Translated using Weblate (Romanian)
  Bump js-yaml from 5.2.3 to 5.3.0 (FreeTubeApp#9675)
  ...
ShiroiKuma0 pushed a commit to ShiroiKuma0/shiroikuma-jiyudoga that referenced this pull request Aug 26, 2026
白い熊 白い熊
Merge FreeTube development (threaded replies, YouTube.js 18, SABR red…
1de9ec4 
…irect)

Seventeen commits, eleven of them Weblate. The substance is FreeTubeApp#9555, threaded
replies on YouTube.js 18.0.0: CommentSection.vue loses 508 lines to a new
FtComment component, parseLocalComment is reshaped (authorLink, showReplies
and replies dropped; replyLevel and a real replyToken added) and both comment
entry points now pass generateSessionLocally: false. Our layer touches no
comment code, so none of that reaches us — but the youtubei.js major is the
one change worth watching at runtime, since getLocalVideoRecommendations and
the study export both ride on that library.

FreeTubeApp#9689 fixes the SABR redirect writing sabrUrl to the wrong object — the same
one-line fix we already made in 6854d93 after the refusals of 2026-08-16,
-20 and -22. Kept ours, which is that fix plus MAX_SABR_REDIRECTS and
logRefusedSabrResponse. The rest is cosmetic: a blacklist/denylist rename in
the proxy header filter, a getRegions script fix, README wording.

Nine locale files conflicted, every one of them our brand substitution against
the extended Invidious Instance tooltip of FreeTubeApp#9464; each took upstream's new
sentence carrying our branding. ja.yaml also took the plural-separator fix on
Comment Count and Like Count — upstream had a fullwidth ｜ there, which
vue-i18n does not accept as a plural delimiter — plus the new Replies
Remaining key, with our Skui Grid block kept. README.md kept ours.

patches/youtubei.js@17.2.0.patch is deleted: YouTube.js 18.0.0 ships it
verbatim, comment and all, and pnpm refused to install while it hung around
unused. patches/mediabunny.patch is unaffected and still applies.

FreeTubeAndroid contributed nothing — we already sit on their development tip,
so their pin holds at 2026-08-12.20-35.gc42fee2c and the shared-history guard
stays satisfied. Neither upstream released, so FORK_VERSION stays 0.25.2 and
the counter keeps running. The FreeTube pin moves to 2026-08-26.07-51.ge7b555a9.

BUILD_NUMBER reaches 42 (build +041).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@absidue absidue absidue approved these changes
@radmorecameron radmorecameron radmorecameron approved these changes
@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: SABR redirects are never followed — the redirect URL is assigned to a property nothing reads, ending in [BAD_HTTP_STATUS: 401]

5 participants

@PikachuEXE @absidue @radmorecameron @efb4f5ff-1298-471a-8973-3d47447115dc @FreeTubeBot