Add disable hardware acceleration setting to experimental settings - #9571
Open
r3dArch wants to merge 1 commit into
Open
Add disable hardware acceleration setting to experimental settings#9571r3dArch wants to merge 1 commit into
r3dArch wants to merge 1 commit into
Conversation
r3dArch
requested review from
PikachuEXE,
absidue and
radmorecameron
as code owners
August 6, 2026 20:43
Member
|
Just wondering, why did you choose to place this in the Experimental Settings? |
Contributor
Author
|
It's mostly just because that is where the Replace HTTP Cache setting is, which I based most of my code on. Although it is something that most users probably shouldn't use since it will hurt performance. Looking through the settings headers, I think the only other spot that makes sense would be "General". Do you have somewhere else you'd prefer this setting to be? |
Contributor
|
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
closes #2296
Description
This PR adds a "Disable Hardware Acceleration" setting to the experimental settings section of the settings page.
Screenshots
Before
After
Testing
I tested that the disable hardware acceleration is actually working using the
electron.app.isHardwareAccelerationEnabled()function which I temporarily added to main/index.js, but I couldn't find a way to determine if it is working using the electron JS console.Desktop
Additional context
I based a lot of this code on the implementation of the Replace HTTP Cache setting.