Feat: Add SponsorBlock channels exclusion list

[Shadorc]

Pull Request Type

• Bugfix
• Feature Implementation
• Documentation
• Other

Related issue

closes #4991

Description

Add an exclusion list setting for SponsorBlock which works the same as the 'Hide Channel' setting.

Screenshots

Testing

1. Go to Settings > SponsorBlock and disable SponsorBlock
2. Go to any video with sponsor segments
3. Check that SponsorBlock is not enabled (watch progress shouldn't display any sponsor segments and the video should play entirely)
4. Go to Trending or Subscriptions and check that the dropdown menu on any video does not have the option "Exclude Channel from SponsorBlock"
5. Go to Settings > SponsorBlock and enable SponsorBlock
6. Go to any video with sponsor segments
7. Check that SponsorBlock is enabled (watch progress should display sponsor segments and the video should skip those segments)
8. Go to Trending or Subscriptions and check that the dropdown menu on any video has the option "Exclude Channel from SponsorBlock"
9. Go to Settings > SponsorBlock and add a channel to Excluded Channels
10. Check that the channel appears in the added item
11. Check that Show Added Items toggle works as expected
12. Go to any video from the excluded channel with sponsor segments
13. Check that the watch progress displays sponsor segments
14. Check that the video plays entirely, no matter the "Skip Options" defined in SponsorBlock settings

Desktop

• OS: bazzite
• OS Version:
• FreeTube version: v0.25.1-beta

[PikachuEXE]

1. The new action is in different category from Hide/Show Channel, please add separator
2. The actual meaning is "channels excluded from SponsorBlock" or "channels with SponsorBlock disabled" or "SponsorBlock disabled channels" not "allowed by SponsorBlock". So the actions should be something like "Exclude channel from SponsorBlock" / "Disable SponsorBlock on channel"

[Shadorc]

@PikachuEXE Thanks for your suggestions. I was not happy with allow/disallow but I didn't think about include/exclude

Also I've added a non-suggested change: the dropdown option is not added anymore if sponsor block is disabled.

[PikachuEXE]

The issue title is Allow whitelisting of channels from Sponsorblock skips so just skips not the segment displays
I don't see benefit in not showing segments for some channels (since they want to watch it, but maybe they also want to skip when some feel boring and it's easier to manually skip those when segments are shown

[efb4f5ff-1298-471a-8973-3d47447115dc]

Thats making an assumption based on the title but they never clarified in the issue if they actually would want to still see the segments appear on the timeline or not

edit: i think i agree with your argument though

[Shadorc]

I agree with PikachuEXE's arguments too
Maybe we could ask users, just to be sure, maybe there will be a consensus, who knows!

[efb4f5ff-1298-471a-8973-3d47447115dc]

If we want I can do a poll on our Discussions page, ping the users that are involved with that issue and throw a link in the matrix general chat.

edit: and hope that users reach a consensus instead a close 40/60 split or something similar

[absidue]

Doing a poll for this just sounds like unnecessary admin work, showing the segments without skipping is non-invasive and as Pika mentioned allows people to still manually skip segments if they want to.

[Shadorc]

I've updated the MR to change the behaviour as discussed.
I've not updated texts because they are still pretty aligned with the new behaviour imo