SFT-7694 Fix fractional text bitmap cache keys - #9
Draft
BitcoinQnA wants to merge 1 commit into
Draft
Conversation
BitcoinQnA
force-pushed
the
codex/text-bitmap-cache-key
branch
from
August 27, 2026 15:56
44f48ea to
d899160
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a software-renderer text bitmap cache collision exposed by the longer Miniscript policy review screens on Passport Prime.
The cache key now distinguishes fractional glyph positions correctly, preventing the out-of-range slice panic seen during policy import.
Context
Without this fix, opening a sufficiently complex imported policy could abort the Bitcoin app in the Slint software renderer with a range-end index panic. This PR is a rendering dependency of the KeyOS SFT-7694 implementation.
Device verification
The fix is included in the latest tested Passport Prime image. The previously reproducible Liana policy-import crash no longer occurs across the completed device QA.
Linear: https://linear.app/foundation-devices/issue/SFT-7694/featured-miniscript-on-bitcoin-app