Add native Unchained Connect Wallet support - #669
Draft
Jacksper13 wants to merge 4 commits into
Draft
Conversation
mjg-foundation
marked this pull request as draft
August 25, 2026 21:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
crypto-hdkeyQR using the legacy nested tags required by UnchainedCompatibility
Unchained sends wallet registration policies as
ur:bytescontaining its Coldcard-style multisig config. Passport Core already unwraps that payload and accepts the format, so no Unchained-specific parser is introduced. Transaction signing remains on the existing standard PSBT QR and microSD paths.This is a first-class firmware integration and does not use the extension system.
Testing
cargo fmt --checkcargo test --features stdcbindgen --config cbindgen.toml --crate foundation --output include/foundation.h --verifypython -m py_compilefor the new wallet and unit-test modulespython -m pycodestylefor the new wallet and unit-test modulesgit diff --checkA full simulator or hardware pairing was not run locally because the Docker simulator and ARM GCC toolchain are unavailable in this environment.